Improve test coverage

Author: rastating

lib/wpxf/modules/auxiliary/file_download/wp_hide_security_enhancer_file_download.rb

@@ -37,7 +37,10 @@ def downloader_url
   end
 
   def download_request_params
-    { 'action' => 'style-clean', 'file_path' => "/#{remote_file}" }
+    {
+      'action' => 'style-clean',
+      'file_path' => "/#{remote_file}"
+    }
   end
 
   def validate_content(content)

spec/lib/wpxf/modules/auxiliary/file_download/simple_download_monitor_file_download_spec.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require_relative '../../../../../spec_helper'
+require 'wpxf/modules'
+
+describe Wpxf::Auxiliary::SimpleDownloadMonitorFileDownload do
+  let(:subject) { described_class.new }
+
+  before :each, 'setup subject' do
+    allow(subject).to receive(:check_plugin_version_from_readme)
+    allow(subject).to receive(:emit_warning)
+  end
+
+  it 'should return a {Wpxf::Module}' do
+    expect(subject).to be_a Wpxf::Module
+  end
+
+  it 'should check the plugin < 3.2.9' do
+    subject.check
+    expect(subject).to have_received(:check_plugin_version_from_readme)
+      .with('simple-download-monitor', '3.2.9')
+      .exactly(1).times
+  end
+
+  it 'should not register the remote file option' do
+    expect(subject.register_remote_file_option?).to be false
+  end
+
+  it 'should not require authentication' do
+    expect(subject.requires_authentication).to be false
+  end
+
+  it 'should configure the downloader url' do
+    expect(subject.downloader_url).to eql subject.wordpress_url_admin_ajax
+  end
+
+  it 'should configure the request params' do
+    subject.set_option_value('post_id', 10)
+    expect(subject.download_request_params).to eql(
+      'action' => 'sdm_init_time_tasks',
+      'smd_process_download' => '1',
+      'download_id' => '10'
+    )
+  end
+
+  it 'should GET the download request' do
+    expect(subject.download_request_method).to eql :get
+  end
+
+  context 'if the download does not appear to be valid' do
+    let(:content) { 'This download item (99) does not have any download link' }
+
+    it 'should emit a warning' do
+      subject.validate_content(content)
+      expect(subject).to have_received(:emit_warning)
+        .with('The file you requested appears to be invalid')
+        .exactly(1).times
+    end
+
+    it 'should not fail validation' do
+      res = subject.validate_content(content)
+      expect(res).to be true
+    end
+  end
+end

spec/lib/wpxf/modules/auxiliary/file_download/simple_image_manipulator_arbitrary_file_download_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require_relative '../../../../../spec_helper'
+require 'wpxf/modules'
+
+describe Wpxf::Auxiliary::SimpleImageManipulatorArbitraryFileDownload do
+  let(:subject) { described_class.new }
+
+  before :each, 'setup subject' do
+    allow(subject).to receive(:check_plugin_version_from_readme)
+  end
+
+  it 'should return a {Wpxf::Module}' do
+    expect(subject).to be_a Wpxf::Module
+  end
+
+  it 'should check the plugin is installed' do
+    subject.check
+    expect(subject).to have_received(:check_plugin_version_from_readme)
+      .with('simple-image-manipulator')
+      .exactly(1).times
+  end
+
+  it 'should register the default remote file path' do
+    expected = '../../../../wp-config.php'
+    expect(subject.default_remote_file_path).to eql expected
+  end
+
+  it 'should not require authentication' do
+    expect(subject.requires_authentication).to be false
+  end
+
+  it 'should configure the working directory' do
+    expected = 'wp-content/plugins/simple-image-manipulator/controller/'
+    expect(subject.working_directory).to eql expected
+  end
+
+  it 'should configure the downloader url' do
+    expected = %r{simple\-image\-manipulator/controller/download\.php}
+    expect(subject.downloader_url).to match(expected)
+  end
+
+  it 'should configure the request params' do
+    subject.set_option_value('remote_file', 'test.php')
+    expect(subject.download_request_params).to eql('filepath' => 'test.php')
+  end
+
+  it 'should GET the download request' do
+    expect(subject.download_request_method).to eql :get
+  end
+end

spec/lib/wpxf/modules/auxiliary/file_download/site_editor_file_download_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+require_relative '../../../../../spec_helper'
+require 'wpxf/modules'
+
+describe Wpxf::Auxiliary::SiteEditorFileDownload do
+  let(:subject) { described_class.new }
+  let(:downloaded_filename) { File.join(Dir.tmpdir, 'wpxf_unit_test') }
+
+  before :each, 'setup subject' do
+    allow(subject).to receive(:check_plugin_version_from_readme)
+    allow(subject).to receive(:downloaded_filename).and_return(downloaded_filename)
+  end
+
+  after :each, 'delete temp files' do
+    FileUtils.rm_f downloaded_filename
+  end
+
+  it 'should return a {Wpxf::Module}' do
+    expect(subject).to be_a Wpxf::Module
+  end
+
+  it 'should check the plugin version is < 1.1.2' do
+    subject.check
+    expect(subject).to have_received(:check_plugin_version_from_readme)
+      .with('site-editor', '1.1.2')
+      .exactly(1).times
+  end
+
+  it 'should register the default remote file path' do
+    expected = '/etc/passwd'
+    expect(subject.default_remote_file_path).to eql expected
+  end
+
+  it 'should not require authentication' do
+    expect(subject.requires_authentication).to be false
+  end
+
+  it 'should configure the working directory' do
+    expected = 'wp-content/plugins/site-editor/editor/extensions/pagebuilder/includes/'
+    expect(subject.working_directory).to eql expected
+  end
+
+  it 'should configure the downloader url' do
+    expected = %r{site\-editor/editor/extensions/pagebuilder/includes/ajax_shortcode_pattern\.php}
+    expect(subject.downloader_url).to match(expected)
+  end
+
+  it 'should configure the request params' do
+    subject.set_option_value('remote_file', '/etc/passwd')
+    expect(subject.download_request_params).to eql('ajax_path' => '/etc/passwd')
+  end
+
+  it 'should GET the download request' do
+    expect(subject.download_request_method).to eql :get
+  end
+
+  it 'should remove junk data from the end of the file during validation' do
+    content = 'root:toor{"success":true,"data":{"output":[]}}'
+    subject.validate_content(content)
+    modified_content = File.read(downloaded_filename)
+    expect(modified_content).to eql 'root:toor'
+  end
+end

spec/lib/wpxf/modules/auxiliary/file_download/wp_background_takeover_file_download_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require_relative '../../../../../spec_helper'
+require 'wpxf/modules'
+
+describe Wpxf::Auxiliary::WpBackgroundTakeoverFileDownload do
+  let(:subject) { described_class.new }
+
+  before :each, 'setup subject' do
+    allow(subject).to receive(:check_plugin_version_from_readme)
+  end
+
+  it 'should return a {Wpxf::Module}' do
+    expect(subject).to be_a Wpxf::Module
+  end
+
+  it 'should check the plugin version is < 4.1.5' do
+    subject.check
+    expect(subject).to have_received(:check_plugin_version_from_readme)
+      .with('wpsite-background-takeover', '4.1.5')
+      .exactly(1).times
+  end
+
+  it 'should register the default remote file path' do
+    expected = '../../../../wp-config.php'
+    expect(subject.default_remote_file_path).to eql expected
+  end
+
+  it 'should not require authentication' do
+    expect(subject.requires_authentication).to be false
+  end
+
+  it 'should configure the working directory' do
+    expected = 'wp-content/plugins/wpsite-background-takeover/exports/'
+    expect(subject.working_directory).to eql expected
+  end
+
+  it 'should configure the downloader url' do
+    expected = %r{wpsite\-background\-takeover/exports/download\.php}
+    expect(subject.downloader_url).to match(expected)
+  end
+
+  it 'should configure the request params' do
+    subject.set_option_value('remote_file', 'wp-config.php')
+    expect(subject.download_request_params).to eql('filename' => 'wp-config.php')
+  end
+
+  it 'should GET the download request' do
+    expect(subject.download_request_method).to eql :get
+  end
+end

spec/lib/wpxf/modules/auxiliary/file_download/wp_hide_security_enhancer_file_download_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+require_relative '../../../../../spec_helper'
+require 'wpxf/modules'
+
+describe Wpxf::Auxiliary::WpHideSecurityEnhancerFileDownload do
+  let(:subject) { described_class.new }
+
+  before :each, 'setup subject' do
+    allow(subject).to receive(:check_plugin_version_from_readme)
+    allow(subject).to receive(:emit_error)
+  end
+
+  it 'should return a {Wpxf::Module}' do
+    expect(subject).to be_a Wpxf::Module
+  end
+
+  it 'should check the plugin version is < 1.3.9.3' do
+    subject.check
+    expect(subject).to have_received(:check_plugin_version_from_readme)
+      .with('wp-hide-security-enhancer', '1.3.9.3')
+      .exactly(1).times
+  end
+
+  it 'should register the default remote file path' do
+    expected = 'wp-config.php'
+    expect(subject.default_remote_file_path).to eql expected
+  end
+
+  it 'should not require authentication' do
+    expect(subject.requires_authentication).to be false
+  end
+
+  it 'should configure the working directory' do
+    expected = 'the WordPress installation directory'
+    expect(subject.working_directory).to eql expected
+  end
+
+  it 'should configure the downloader url' do
+    expected = %r{wp\-hide\-security\-enhancer/router/file\-process\.php}
+    expect(subject.downloader_url).to match(expected)
+  end
+
+  it 'should configure the request params' do
+    subject.set_option_value('remote_file', 'wp-config.php')
+    expect(subject.download_request_params).to eql(
+      'action' => 'style-clean',
+      'file_path' => '/wp-config.php'
+    )
+  end
+
+  it 'should GET the download request' do
+    expect(subject.download_request_method).to eql :get
+  end
+
+  context 'if no content is received' do
+    it 'should emit an error' do
+      subject.validate_content('')
+      expect(subject).to have_received(:emit_error)
+        .with('No content returned, file may not exist.')
+        .exactly(1).times
+    end
+
+    it 'should fail the validation process' do
+      res = subject.validate_content('')
+      expect(res).to be false
+    end
+  end
+end