Add AB post-image #133
Open
Add AB post-image #133
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While runner can support X|Y logic for hooks, since the generic post-image hook creates the IDP JSON, we want both image specific and generic post-image hooks to run. Other hooks are not mutually exclusive, so remove the logic for post-image since it serves no purpose.
pelwell
reviewed
Dec 1, 2025
image/gpt/ab_userdata/post-image.sh
Outdated
| set -eu | ||
|
|
||
| upd="${1}/update" | ||
| rm -rf "${1}/update" |
Contributor
There was a problem hiding this comment.
Is there any reason this shouldn't be rm -rf $upd?
image/gpt/ab_userdata/post-image.sh
Outdated
| ln -sf ../boot.sparse ${upd}/boot | ||
|
|
||
| msg "Packing..." | ||
| tar -I zstd -h -cf ${1}/update.tar.zst -C $upd . |
Contributor
There was a problem hiding this comment.
This looks neater than the version I was using, but it has the unfortunate side effect of generating entries in the tar file beginning ./, which causes problems because the name doesn't match that of one of the A/B slots. Could you use this instead?
(cd $upd; tar -I zstd -h -cf ${1}/update.tar.zst *)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove mutual exclusion for post-image hooks - it's not needed.
Plug in a simple post-image hook for the AB layout that packs a compressed archive of slot sparse images.
fyi @pelwell @clowder