Skip to content

Commit eeb91b1

Browse files
Copilotrashidi
andauthored
Fix deprecated API usage patterns (#271)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rashidi <380073+rashidi@users.noreply.github.com>
1 parent b9f9a1a commit eeb91b1

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

batch-rest-repository/src/main/java/zin/rashidi/boot/batch/rest/user/UserJobConfiguration.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
@Configuration
2727
class UserJobConfiguration {
2828

29+
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
30+
2931
private final JobRepository jobRepository;
3032
private final PlatformTransactionManager transactionManager;
3133
private final MongoOperations mongo;
@@ -52,7 +54,7 @@ private Step step() throws MalformedURLException {
5254
private JsonItemReader<User> reader() throws MalformedURLException {
5355
JacksonJsonObjectReader<User> jsonObjectReader = new JacksonJsonObjectReader<>(User.class);
5456

55-
jsonObjectReader.setMapper(new ObjectMapper());
57+
jsonObjectReader.setMapper(OBJECT_MAPPER);
5658

5759
return new JsonItemReaderBuilder<User>()
5860
.name("userReader")

batch-skip-step/src/main/java/zin/rashidi/boot/batch/user/UserJobConfiguration.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import org.springframework.batch.core.repository.JobRepository;
88
import org.springframework.batch.core.step.builder.StepBuilder;
99
import org.springframework.batch.item.ItemProcessor;
10-
import org.springframework.batch.item.database.ItemPreparedStatementSetter;
1110
import org.springframework.batch.item.database.JdbcBatchItemWriter;
1211
import org.springframework.batch.item.database.builder.JdbcBatchItemWriterBuilder;
1312
import org.springframework.batch.item.json.JacksonJsonObjectReader;
@@ -19,19 +18,19 @@
1918
import org.springframework.transaction.PlatformTransactionManager;
2019

2120
import javax.sql.DataSource;
22-
import java.sql.PreparedStatement;
23-
import java.sql.SQLException;
2421

2522
/**
2623
* @author Rashidi Zin
2724
*/
2825
@Configuration
2926
class UserJobConfiguration {
3027

28+
private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
29+
3130
private JsonItemReader<UserFile> reader() {
3231
JacksonJsonObjectReader<UserFile> reader = new JacksonJsonObjectReader<>(UserFile.class);
3332

34-
reader.setMapper(new ObjectMapper());
33+
reader.setMapper(OBJECT_MAPPER);
3534

3635
return new JsonItemReaderBuilder<UserFile>()
3736
.jsonObjectReader(reader)

data-mongodb-full-text-search/src/main/java/zin/rashidi/boot/data/mongodb/character/CharacterSearchRepositoryImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import org.springframework.data.domain.Sort;
66
import org.springframework.data.mongodb.core.MongoOperations;
7-
import org.springframework.data.mongodb.core.index.TextIndexDefinition.TextIndexDefinitionBuilder;
7+
import org.springframework.data.mongodb.core.index.TextIndexDefinition;
88
import org.springframework.data.mongodb.core.query.TextCriteria;
99
import org.springframework.data.mongodb.core.query.TextQuery;
1010

@@ -22,7 +22,7 @@ class CharacterSearchRepositoryImpl implements CharacterSearchRepository {
2222
@Override
2323
public List<Character> findByText(String text, Sort sort) {
2424
operations.indexOps(Character.class)
25-
.createIndex(new TextIndexDefinitionBuilder().onFields("name", "publisher").build());
25+
.createIndex(TextIndexDefinition.builder().onFields("name", "publisher").build());
2626

2727
var parameters = text.split(" ");
2828
var query = TextQuery.queryText(new TextCriteria().matchingAny(parameters)).with(sort);

data-mongodb-full-text-search/src/test/java/zin/rashidi/boot/data/mongodb/character/CharacterRepositoryTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import org.springframework.boot.testcontainers.service.connection.ServiceConnection;
1414
import org.springframework.data.domain.Sort;
1515
import org.springframework.data.mongodb.core.MongoOperations;
16-
import org.springframework.data.mongodb.core.index.TextIndexDefinition.TextIndexDefinitionBuilder;
16+
import org.springframework.data.mongodb.core.index.TextIndexDefinition;
1717
import org.springframework.data.mongodb.core.query.TextCriteria;
1818
import org.testcontainers.containers.MongoDBContainer;
1919
import org.testcontainers.junit.jupiter.Container;
@@ -40,7 +40,7 @@ class CharacterRepositoryTests {
4040
@DisplayName("Generated query: Search for 'captain marvel' should return 'Captain Marvel' and 'Thanos'")
4141
void withGeneratedQuery() {
4242
// Simulate predefined index
43-
operations.indexOps(Character.class).ensureIndex(new TextIndexDefinitionBuilder().onFields("name", "publisher").build());
43+
operations.indexOps(Character.class).ensureIndex(TextIndexDefinition.builder().onFields("name", "publisher").build());
4444

4545
var characters = repository.findAllBy(new TextCriteria().matchingAny("captain", "marvel"), Sort.by("name"));
4646

0 commit comments

Comments
 (0)