Separate Sonar checks (#278)

Author: rashidi

.github/workflows/gradle-build.yml

@@ -29,6 +29,7 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       build-changes: ${{ steps.filter.outputs.build }}
+      source-changes: ${{ steps.filter.outputs.java }}
     steps:
       - uses: actions/checkout@v5
         with:
@@ -42,13 +43,50 @@ jobs:
               - '**/*.gradle.kts'
               - '**/gradle-build.yml'
               - 'gradle.properties'
+            java:
               - '**/*.java'
-
+    
   gradle-build:
     name: Build project with Gradle
     needs: check-changes
     if: ${{ needs.check-changes.outputs.build-changes == 'true' }}
     runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0      
+      - name: Set up JDK
+        uses: actions/setup-java@v5
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+          cache: 'gradle'
+      - name: Setup Gradle
+        uses: gradle/actions/setup-gradle@v4
+        with:
+          add-job-summary-as-pr-comment: on-failure
+          build-scan-publish: true
+          build-scan-terms-of-use-url: "https://gradle.com/terms-of-service"
+          build-scan-terms-of-use-agree: "yes"
+          cache-encryption-key: ${{ secrets.GRADLE_ENCRYPTION_KEY }}
+      - name: Setup Testcontainers Cloud Client
+        uses: atomicjar/testcontainers-cloud-setup-action@v1
+        with:
+          token: ${{ secrets.TC_CLOUD_TOKEN }}          
+      - name: Run CI build
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: ./gradlew check --configuration-cache
+      - name: Terminate Testcontainers Cloud Client active sessions
+        uses: atomicjar/testcontainers-cloud-setup-action@v1
+        with:
+          action: terminate
+
+  code-quality:
+    name: Code Quality with Sonar
+    needs: check-changes
+    if: ${{ needs.check-changes.outputs.source-changes == 'true' }}
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
         with:
@@ -76,16 +114,12 @@ jobs:
       - name: Setup Testcontainers Cloud Client
         uses: atomicjar/testcontainers-cloud-setup-action@v1
         with:
-          token: ${{ secrets.TC_CLOUD_TOKEN }}          
-      - name: Run CI build
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: ./gradlew check --configuration-cache
+          token: ${{ secrets.TC_CLOUD_TOKEN }}
       - name: Publish Sonar report
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}      
-        run: ./gradlew sonar
+        run: ./gradlew check sonar
       - name: Terminate Testcontainers Cloud Client active sessions
         uses: atomicjar/testcontainers-cloud-setup-action@v1
         with:
-          action: terminate        
+          action: terminate

data-mongodb-tc-data-load/src/test/java/zin/rashidi/data/mongodb/tc/dataload/user/UserRepositoryTests.java

@@ -7,9 +7,7 @@
 import org.springframework.boot.test.context.TestConfiguration;
 import org.springframework.boot.testcontainers.service.connection.ServiceConnection;
 import org.springframework.context.annotation.Bean;
-import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.ComponentScan.Filter;
-import org.springframework.context.annotation.FilterType;
 import org.springframework.core.io.ClassPathResource;
 import org.springframework.core.io.Resource;
 import org.springframework.data.repository.init.Jackson2RepositoryPopulatorFactoryBean;

graphql/src/test/java/zin/rashidi/boot/graphql/book/BookResourceTests.java

@@ -10,7 +10,6 @@
 import org.springframework.stereotype.Repository;
 
 import static org.springframework.context.annotation.FilterType.ANNOTATION;
-import static org.springframework.context.annotation.FilterType.ASSIGNABLE_TYPE;
 
 /**
  * @author Rashidi Zin

modulith/src/main/java/zin/rashidi/boot/modulith/subscription/Subscription.java

@@ -13,7 +13,7 @@ class Subscription {
     private Long id;
     private final Long studentId;
     private final Long courseId;
-    private Status status;
+    private final Status status;
 
     public Subscription(Long studentId, Long courseId) {
         this.studentId = studentId;

test-execution-listeners/src/test/java/zin/rashidi/boot/test/user/UserDeletionTestExecutionListener.java

@@ -11,7 +11,7 @@
  */
 class UserDeletionTestExecutionListener extends AbstractTestExecutionListener {
 
-    private static Logger log = LoggerFactory.getLogger(UserDeletionTestExecutionListener.class);
+    private static final Logger log = LoggerFactory.getLogger(UserDeletionTestExecutionListener.class);
 
     @Override
     public void afterTestClass(TestContext testContext) {

test-execution-listeners/src/test/java/zin/rashidi/boot/test/user/UserRepositoryTests.java

@@ -13,7 +13,6 @@
 import org.testcontainers.containers.MongoDBContainer;
 import org.testcontainers.junit.jupiter.Container;
 import org.testcontainers.junit.jupiter.Testcontainers;
-import org.testcontainers.utility.DockerImageName;
 
 /**
  * @author Rashidi Zin