Skip to content

Commit 2a40976

Browse files
committed
Fix to use defer instead of async to ensure script loading order
Refs. #3513 cf. https://stackoverflow.com/a/39711009
1 parent 4a8cc9e commit 2a40976

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

app/views/layouts/rails_admin/_head.html.erb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66
<% case RailsAdmin::config.asset_source
77
when :webpacker %>
88
<%= stylesheet_pack_tag "rails_admin", data: {'turbo-track': 'reload'} %>
9-
<%= javascript_pack_tag "rails_admin", async: true, data: {'turbo-track': 'reload'} %>
9+
<%= javascript_pack_tag "rails_admin", defer: true, data: {'turbo-track': 'reload'} %>
1010
<% when :sprockets %>
1111
<% handle_asset_dependency_error do %>
1212
<%= stylesheet_link_tag "rails_admin/application.css", media: :all, data: {'turbo-track': 'reload'} %>
13-
<%= javascript_include_tag "rails_admin/application.js", async: true, data: {'turbo-track': 'reload'} %>
13+
<%= javascript_include_tag "rails_admin/application.js", defer: true, data: {'turbo-track': 'reload'} %>
1414
<% end %>
1515
<% when :webpack %>
1616
<%= stylesheet_link_tag "rails_admin.css", media: :all, data: {'turbo-track': 'reload'} %>
17-
<%= javascript_include_tag "rails_admin.js", async: true, data: {'turbo-track': 'reload'} %>
17+
<%= javascript_include_tag "rails_admin.js", defer: true, data: {'turbo-track': 'reload'} %>
1818
<% when :importmap %>
1919
<%= stylesheet_link_tag "rails_admin.css", media: :all, data: {'turbo-track': 'reload'} %>
2020
<%= javascript_inline_importmap_tag(RailsAdmin::Engine.importmap.to_json(resolver: self)) %>

0 commit comments

Comments
 (0)