From ed7de40f72e024e02c7a38d08b8005612acc17f2 Mon Sep 17 00:00:00 2001
From: Sean Doyle <sean.p.doyle24@gmail.com>
Date: Sun, 2 Nov 2025 20:00:09 -0500
Subject: [PATCH] Raise errors to suggest completing class configuration

Prior to this commit, the following error is raised when executing
`Base.find`:

```
NoMethodError: undefined method `path' for nil
```

Similarly, `.collection_url` and `.element_url` invocations raise a
similar error:

```
bad argument (expected URI object or URI string)
```

This commit improves the error messages raised when attempting to use an
`ActiveResource::Base` class that hasn't yet been configured with a
`.site` class attribute.

The `Missing site URI` message raised as an `ArgumentError` mirror the
one raised by [ActiveResource::Connection#initialize][].

[ActiveResource::Connection#initialize]: https://github.com/rails/activeresource/blob/v6.2.0/lib/active_resource/connection.rb#L34
---
 lib/active_resource/base.rb   |  3 +++
 test/cases/base_test.rb       | 14 ++++++++++++++
 test/cases/connection_test.rb |  6 ++++++
 3 files changed, 23 insertions(+)

diff --git a/lib/active_resource/base.rb b/lib/active_resource/base.rb
index edf92e5c25..e9b360258b 100644
--- a/lib/active_resource/base.rb
+++ b/lib/active_resource/base.rb
@@ -795,6 +795,7 @@ def primary_key
       # Gets the \prefix for a resource's nested URL (e.g., <tt>prefix/collectionname/1.json</tt>)
       # This method is regenerated at runtime based on what the \prefix is set to.
       def prefix(options = {})
+        raise ArgumentError, "Missing site URI" unless site
         default = site.path
         default << "/" unless default[-1..-1] == "/"
         # generate the actual method based on the current site path
@@ -899,6 +900,7 @@ def element_path(id, prefix_options = {}, query_options = nil)
       #   # => https://37s.sunrise.com/posts/5/comments/1.json?active=1
       #
       def element_url(id, prefix_options = {}, query_options = nil)
+        raise ArgumentError, "Missing site URI" unless site
         URI.join(site, element_path(id, prefix_options, query_options)).to_s
       end
 
@@ -971,6 +973,7 @@ def collection_path(prefix_options = {}, query_options = nil)
       #   # => https://example.com/posts/5/comments.json?active=1
       #
       def collection_url(prefix_options = {}, query_options = nil)
+        raise ArgumentError, "Missing site URI" unless site
         URI.join(site, collection_path(prefix_options, query_options)).to_s
       end
 
diff --git a/test/cases/base_test.rb b/test/cases/base_test.rb
index 462920ac92..4ca2544646 100644
--- a/test/cases/base_test.rb
+++ b/test/cases/base_test.rb
@@ -33,6 +33,20 @@ def teardown
   # Tests relating to setting up the API-connection configuration
   ########################################################################
 
+  def test_site_missing_error_message
+    Person.site = nil
+
+    assert_raises ArgumentError, match: "Missing site URI" do
+      Person.find(1)
+    end
+    assert_raises ArgumentError, match: "Missing site URI" do
+      Person.element_url(1)
+    end
+    assert_raises ArgumentError, match: "Missing site URI" do
+      Person.collection_url(1)
+    end
+  end
+
   def test_site_accessor_accepts_uri_or_string_argument
     site = URI.parse("http://localhost")
 
diff --git a/test/cases/connection_test.rb b/test/cases/connection_test.rb
index 9be07f4917..03f5d39f02 100644
--- a/test/cases/connection_test.rb
+++ b/test/cases/connection_test.rb
@@ -345,6 +345,12 @@ def test_disable_net_connection
     end
   end
 
+  def test_site_missing_error_message
+    assert_raises ArgumentError, match: "Missing site URI" do
+      ActiveResource::Connection.new(nil)
+    end
+  end
+
   def keep_net_connection_status
     old = ActiveResource::HttpMock.net_connection_enabled?
     begin