re: RuboCop - replace rocket style hashes

Author: dubadub

.rubocop_todo.yml

@@ -45,14 +45,6 @@ Style/ClassAndModuleChildren:
 
 
 
-# Offense count: 58
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
-# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
-Style/HashSyntax:
-  Enabled: false
-
-
 # Offense count: 3
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
 # NamePrefix: is_, has_, have_

Rakefile

@@ -100,4 +100,4 @@ else
 end
 
 desc 'CI test task'
-task :ci => [:default]
+task ci: [:default]

lib/active_model_serializers/railtie.rb

@@ -23,7 +23,7 @@ class Railtie < Rails::Railtie
     # This hook is run after the action_controller railtie has set the configuration
     # based on the *environment* configuration and before any config/initializers are run
     # and also before eager_loading (if enabled).
-    initializer 'active_model_serializers.set_configs', :after => 'action_controller.set_configs' do
+    initializer 'active_model_serializers.set_configs', after: 'action_controller.set_configs' do
       ActiveModelSerializers.logger = Rails.configuration.action_controller.logger
       ActiveModelSerializers.config.perform_caching = Rails.configuration.action_controller.perform_caching
       # We want this hook to run after the config has been set, even if ActionController has already loaded.

lib/active_model_serializers/register_jsonapi_renderer.rb

@@ -53,7 +53,7 @@ def self.install
   def self.parser
     lambda do |body|
       data = JSON.parse(body)
-      data = { :_json => data } unless data.is_a?(Hash)
+      data = { _json: data } unless data.is_a?(Hash)
       data.with_indifferent_access
     end
   end

lib/generators/rails/serializer_generator.rb

@@ -2,11 +2,11 @@ module Rails
   module Generators
     class SerializerGenerator < NamedBase
       source_root File.expand_path('../templates', __FILE__)
-      check_class_collision :suffix => 'Serializer'
+      check_class_collision suffix: 'Serializer'
 
-      argument :attributes, :type => :array, :default => [], :banner => 'field:type field:type'
+      argument :attributes, type: :array, default: [], banner: 'field:type field:type'
 
-      class_option :parent, :type => :string, :desc => 'The parent class for the generated serializer'
+      class_option :parent, type: :string, desc: 'The parent class for the generated serializer'
 
       def create_serializer_file
         template 'serializer.rb.erb', File.join('app/serializers', class_path, "#{file_name}_serializer.rb")

test/action_controller/json_api/errors_test.rb

@@ -8,12 +8,11 @@ def test_active_model_with_multiple_errors
           get :render_resource_with_errors
 
           expected_errors_object = {
-            :errors =>
-              [
-                { :source => { :pointer => '/data/attributes/name' }, :detail => 'cannot be nil' },
-                { :source => { :pointer => '/data/attributes/name' }, :detail => 'must be longer' },
-                { :source => { :pointer => '/data/attributes/id' }, :detail => 'must be a uuid' }
-              ]
+            errors:               [
+              { source: { pointer: '/data/attributes/name' }, detail: 'cannot be nil' },
+              { source: { pointer: '/data/attributes/name' }, detail: 'must be longer' },
+              { source: { pointer: '/data/attributes/id' }, detail: 'must be a uuid' }
+            ]
           }.to_json
           assert_equal json_reponse_body.to_json, expected_errors_object
         end

test/action_controller/json_api/linked_test.rb

@@ -87,7 +87,7 @@ def render_collection_with_include
         setup do
           @routes = Rails.application.routes.draw do
             ActiveSupport::Deprecation.silence do
-              match ':action', :to => LinkedTestController, via: [:get, :post]
+              match ':action', to: LinkedTestController, via: [:get, :post]
             end
           end
         end

test/active_model_serializers/key_transform_test.rb

@@ -5,16 +5,16 @@ def test_camel
     obj = Object.new
     scenarios = [
       {
-        value: { :"some-key" => 'value' },
-        expected: { :SomeKey => 'value' }
+        value: { "some-key": 'value' },
+        expected: { SomeKey: 'value' }
       },
       {
-        value: { :someKey => 'value' },
-        expected: { :SomeKey => 'value' }
+        value: { someKey: 'value' },
+        expected: { SomeKey: 'value' }
       },
       {
-        value: { :some_key => 'value' },
-        expected: { :SomeKey => 'value' }
+        value: { some_key: 'value' },
+        expected: { SomeKey: 'value' }
       },
       {
         value: { 'some-key' => 'value' },
@@ -71,16 +71,16 @@ def test_camel_lower
     obj = Object.new
     scenarios = [
       {
-        value: { :"some-key" => 'value' },
-        expected: { :someKey => 'value' }
+        value: { "some-key": 'value' },
+        expected: { someKey: 'value' }
       },
       {
-        value: { :SomeKey => 'value' },
-        expected: { :someKey => 'value' }
+        value: { SomeKey: 'value' },
+        expected: { someKey: 'value' }
       },
       {
-        value: { :some_key => 'value' },
-        expected: { :someKey => 'value' }
+        value: { some_key: 'value' },
+        expected: { someKey: 'value' }
       },
       {
         value: { 'some-key' => 'value' },
@@ -137,24 +137,24 @@ def test_dash
     obj = Object.new
     scenarios = [
       {
-        value: { :some_key => 'value' },
-        expected: { :"some-key" => 'value' }
+        value: { some_key: 'value' },
+        expected: { "some-key": 'value' }
       },
       {
         value: { 'some_key' => 'value' },
         expected: { 'some-key' => 'value' }
       },
       {
-        value: { :SomeKey => 'value' },
-        expected: { :"some-key" => 'value' }
+        value: { SomeKey: 'value' },
+        expected: { "some-key": 'value' }
       },
       {
         value: { 'SomeKey' => 'value' },
         expected: { 'some-key' => 'value' }
       },
       {
-        value: { :someKey => 'value' },
-        expected: { :"some-key" => 'value' }
+        value: { someKey: 'value' },
+        expected: { "some-key": 'value' }
       },
       {
         value: { 'someKey' => 'value' },
@@ -199,24 +199,24 @@ def test_underscore
     obj = Object.new
     scenarios = [
       {
-        value: { :"some-key" => 'value' },
-        expected: { :some_key => 'value' }
+        value: { "some-key": 'value' },
+        expected: { some_key: 'value' }
       },
       {
         value: { 'some-key' => 'value' },
         expected: { 'some_key' => 'value' }
       },
       {
-        value: { :SomeKey => 'value' },
-        expected: { :some_key => 'value' }
+        value: { SomeKey: 'value' },
+        expected: { some_key: 'value' }
       },
       {
         value: { 'SomeKey' => 'value' },
         expected: { 'some_key' => 'value' }
       },
       {
-        value: { :someKey => 'value' },
-        expected: { :some_key => 'value' }
+        value: { someKey: 'value' },
+        expected: { some_key: 'value' }
       },
       {
         value: { 'someKey' => 'value' },

test/active_model_serializers/register_jsonapi_renderer_test_isolated.rb

@@ -44,7 +44,7 @@ class WithoutRenderer < JsonApiRendererTest
 
       Rails.application.routes.draw do
         ActiveSupport::Deprecation.silence do
-          match ':action', :to => TestController, via: [:get, :post]
+          match ':action', to: TestController, via: [:get, :post]
         end
       end
     end
@@ -95,7 +95,7 @@ class WithRenderer < JsonApiRendererTest
 
       Rails.application.routes.draw do
         ActiveSupport::Deprecation.silence do
-          match ':action', :to => TestController, via: [:get, :post]
+          match ':action', to: TestController, via: [:get, :post]
         end
       end
     end

test/adapter/json/transform_test.rb

@@ -63,7 +63,7 @@ def test_transform_undefined
         def test_transform_dash
           mock_request(:dash)
           assert_equal({
-                         blog: { id: 1, :"special-attribute" => 'neat', articles: nil }
+                         blog: { id: 1, "special-attribute": 'neat', articles: nil }
                        }, @adapter.serializable_hash)
         end