consider non-test and non-tmc subdirectories to be student files in python policy

Author: Heliozoa

plugins/python3/README.md

@@ -4,7 +4,7 @@ The plugin creates a warning when the Python used is detected to be older than t
 
 ## Student file policy
 
-All files inside `./src` are considered student files, except for files with a `pyc` extension and files inside a `__pycache__` directory. In addition, all files in the project root with a `.py` extension are considered student files.
+All files inside `./src` are considered student files, except for files with a `pyc` extension and files inside a `__pycache__` directory. In addition, all files in the project root with a `.py` extension are considered student files. All files in directories other than `./test` and `./tmc` are considered student files, except for files with a `pyc` extension and files inside a `__pycache__` directory.
 
 ### Example
 
@@ -13,11 +13,15 @@ All files inside `./src` are considered student files, except for files with a `
 ./src/file
 ./src/subdirectory/file
 ./root.py
+./dir/any_non_cache_file
 
 # Not student files
-./tests/test_file
+./test/test_file
 ./src/file.pyc
 ./src/__pycache__/file
+./file_in_root
+./dir/cache_file.pyc
+./dir/__pycache__/cache_file
 ```
 
 ## Environment variables

plugins/python3/src/policy.rs

@@ -36,7 +36,12 @@ impl StudentFilePolicy for Python3StudentFilePolicy {
         };
         let is_py_file = path.extension() == Some(OsStr::new("py"));
 
-        in_src && !is_cache_file || is_in_project_root && is_py_file
+        // all files in non-tmc and non-test subdirectories are considered student files
+        let is_in_exercise_subdir = path.starts_with("test") || path.starts_with("tmc");
+
+        in_src && !is_cache_file
+            || is_in_project_root && is_py_file
+            || !is_in_exercise_subdir && !is_in_project_root && !is_cache_file
     }
 }
 
@@ -76,4 +81,25 @@ mod test {
         assert!(!policy.is_student_source_file(Path::new("some.pyc")));
         assert!(!policy.is_student_source_file(Path::new("src/other.pyc")));
     }
+
+    #[test]
+    fn subdirs_are_student_files() {
+        let policy = Python3StudentFilePolicy::new(PathBuf::from(""));
+        assert!(policy.is_student_source_file(Path::new("subdir/something")));
+        assert!(policy.is_student_source_file(Path::new("another/mid/else")));
+    }
+
+    #[test]
+    fn tmc_and_test_are_not_student_files() {
+        let policy = Python3StudentFilePolicy::new(PathBuf::from(""));
+        assert!(policy.is_student_source_file(Path::new("subdir/something")));
+        assert!(policy.is_student_source_file(Path::new("another/mid/else")));
+    }
+
+    #[test]
+    fn non_py_file_in_root_is_not_student_file() {
+        let policy = Python3StudentFilePolicy::new(PathBuf::from(""));
+        assert!(!policy.is_student_source_file(Path::new("test")));
+        assert!(!policy.is_student_source_file(Path::new("root_file")));
+    }
 }