fixed clippy lints

Author: Heliozoa

plugins/csharp/src/cs_test_result.rs

@@ -7,6 +7,7 @@ use tmc_langs_framework::TestResult;
 /// Test result from the C# test runner.
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "PascalCase")]
+#[allow(clippy::upper_case_acronyms)]
 pub struct CSTestResult {
     pub name: String,
     pub passed: bool,

plugins/csharp/src/error.rs

@@ -32,8 +32,8 @@ impl From<CSharpError> for TmcError {
 }
 
 // conversion from plugin error to a tmc result
-impl<T> Into<Result<T, TmcError>> for CSharpError {
-    fn into(self) -> Result<T, TmcError> {
-        Err(TmcError::Plugin(Box::new(self)))
+impl<T> From<CSharpError> for Result<T, TmcError> {
+    fn from(from: CSharpError) -> Self {
+        Err(TmcError::Plugin(Box::new(from)))
     }
 }

plugins/java/src/error.rs

@@ -47,8 +47,8 @@ impl From<JavaError> for TmcError {
 }
 
 // conversion from plugin error to a tmc result
-impl<T> Into<Result<T, TmcError>> for JavaError {
-    fn into(self) -> Result<T, TmcError> {
-        Err(TmcError::Plugin(Box::new(self)))
+impl<T> From<JavaError> for Result<T, TmcError> {
+    fn from(from: JavaError) -> Self {
+        Err(TmcError::Plugin(Box::new(from)))
     }
 }

plugins/java/src/java_plugin.rs

@@ -47,7 +47,7 @@ pub(crate) trait JavaPlugin: LanguagePlugin {
             self.create_run_result_file(project_root_path, timeout, compile_result)?;
         let result = self.parse_test_result(&test_result);
         file_util::remove_file(&test_result.test_results)?;
-        Ok(result?)
+        result
     }
 
     /// Parses test results.

plugins/make/src/error.rs

@@ -38,8 +38,8 @@ impl From<MakeError> for TmcError {
 }
 
 // conversion from plugin error to a tmc result
-impl<T> Into<Result<T, TmcError>> for MakeError {
-    fn into(self) -> Result<T, TmcError> {
-        Err(TmcError::Plugin(Box::new(self)))
+impl<T> From<MakeError> for Result<T, TmcError> {
+    fn from(from: MakeError) -> Self {
+        Err(TmcError::Plugin(Box::new(from)))
     }
 }

plugins/python3/src/error.rs

@@ -39,8 +39,8 @@ impl From<PythonError> for TmcError {
 }
 
 // conversion from plugin error to a tmc result
-impl<T> Into<Result<T, TmcError>> for PythonError {
-    fn into(self) -> Result<T, TmcError> {
-        Err(TmcError::Plugin(Box::new(self)))
+impl<T> From<PythonError> for Result<T, TmcError> {
+    fn from(from: PythonError) -> Self {
+        Err(TmcError::Plugin(Box::new(from)))
     }
 }

plugins/r/src/error.rs

@@ -24,8 +24,8 @@ impl From<RError> for TmcError {
 }
 
 // conversion from plugin error to a tmc result
-impl<T> Into<Result<T, TmcError>> for RError {
-    fn into(self) -> Result<T, TmcError> {
-        Err(TmcError::Plugin(Box::new(self)))
+impl<T> From<RError> for Result<T, TmcError> {
+    fn from(from: RError) -> Self {
+        Err(TmcError::Plugin(Box::new(from)))
     }
 }

tmc-langs-util/src/file_util.rs

@@ -150,7 +150,7 @@ pub fn write_to_writer<S: AsRef<[u8]>, W: Write>(
 ) -> Result<(), FileError> {
     target
         .write_all(source.as_ref())
-        .map_err(|e| FileError::WriteError(e))?;
+        .map_err(FileError::WriteError)?;
     Ok(())
 }