Vec<u8> in FailedCommand

Author: Heliozoa

plugins/java/src/ant.rs

@@ -178,8 +178,8 @@ impl LanguagePlugin for AntPlugin {
             Err(JavaError::FailedCommand(
                 "ant clean".to_string(),
                 output.status,
-                output.stdout,
-                output.stderr,
+                String::from_utf8_lossy(&output.stdout).into_owned(),
+                String::from_utf8_lossy(&output.stderr).into_owned(),
             )
             .into())
         }

plugins/java/src/error.rs

@@ -16,12 +16,14 @@ pub enum JavaError {
     InvalidExercise(PathBuf),
     #[error("Failed to run {0}")]
     FailedToRun(String, #[source] std::io::Error),
-    #[error(r"Command '{0}' exited with a exit status {1}
+    #[error(
+        r"Command '{0}' exited with a exit status {1}
 #### STDOUT ####
-{}
+{2}
 #### STDERR ####
-{}", String::from_utf8_lossy(&.2), String::from_utf8_lossy(&.3))]
-    FailedCommand(String, ExitStatus, Vec<u8>, Vec<u8>),
+{3}"
+    )]
+    FailedCommand(String, ExitStatus, String, String),
     #[error("Failed to write temporary .jar file {0}")]
     JarWrite(PathBuf, #[source] io::Error),
     #[error("Failed to create file at {0}")]

plugins/java/src/maven.rs

@@ -137,8 +137,8 @@ impl LanguagePlugin for MavenPlugin {
             return Err(JavaError::FailedCommand(
                 "mvn".to_string(),
                 output.status,
-                output.stdout,
-                output.stderr,
+                String::from_utf8_lossy(&output.stdout).into_owned(),
+                String::from_utf8_lossy(&output.stderr).into_owned(),
             )
             .into());
         }
@@ -186,8 +186,8 @@ impl JavaPlugin for MavenPlugin {
             return Err(JavaError::FailedCommand(
                 mvn_path.as_os_str().to_string_lossy().to_string(),
                 output.status,
-                output.stdout,
-                output.stderr,
+                String::from_utf8_lossy(&output.stdout).into_owned(),
+                String::from_utf8_lossy(&output.stderr).into_owned(),
             ));
         }
 
@@ -229,8 +229,8 @@ impl JavaPlugin for MavenPlugin {
             return Err(JavaError::FailedCommand(
                 mvn_path.as_os_str().to_string_lossy().to_string(),
                 output.status,
-                output.stdout,
-                output.stderr,
+                String::from_utf8_lossy(&output.stdout).into_owned(),
+                String::from_utf8_lossy(&output.stderr).into_owned(),
             ));
         }
 
@@ -264,8 +264,8 @@ impl JavaPlugin for MavenPlugin {
             return Err(JavaError::FailedCommand(
                 mvn_path.as_os_str().to_string_lossy().to_string(),
                 output.status,
-                output.stdout,
-                output.stderr,
+                String::from_utf8_lossy(&output.stdout).into_owned(),
+                String::from_utf8_lossy(&output.stderr).into_owned(),
             ));
         }
 

plugins/java/src/plugin.rs

@@ -127,8 +127,8 @@ pub(crate) trait JavaPlugin: LanguagePlugin {
             return Err(JavaError::FailedCommand(
                 "java".to_string(),
                 output.status,
-                output.stdout,
-                output.stderr,
+                String::from_utf8_lossy(&output.stdout).into_owned(),
+                String::from_utf8_lossy(&output.stderr).into_owned(),
             ));
         }