Skip to content

Commit 5ccce43

Browse files
TheCodedProfsebastinez
authored andcommitted
feat(web): Display assignees as nodes
Previously assignees were displayed using a chip, which while it looked nice had the following issues: - It only showed the node ID rather than the alias (and actually the node ID was cut off) - It wasn't clickable to go to the user's profile - It was not a consistent experience with the rest of the users displayed around the application (e.g. in reviews, uploader, branches view).
1 parent d37ccde commit 5ccce43

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/views/repos/Cob/Assignees.svelte

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
<script lang="ts">
2-
import type { BaseUrl, Reaction } from "@http-client";
3-
4-
import Badge from "@app/components/Badge.svelte";
2+
import type { Reaction, BaseUrl } from "@http-client";
53
import NodeId from "@app/components/NodeId.svelte";
64
75
export let baseUrl: BaseUrl;
@@ -17,6 +15,7 @@
1715
display: flex;
1816
flex-wrap: wrap;
1917
flex-direction: row;
18+
width: 100%;
2019
gap: 0.5rem;
2120
font-size: var(--font-size-small);
2221
}
@@ -34,7 +33,8 @@
3433
align-items: center;
3534
}
3635
.body {
37-
align-items: flex-start;
36+
align-items: center;
37+
align-self: center;
3838
}
3939
.no-assignees {
4040
height: 2rem;
@@ -47,10 +47,10 @@
4747
<div class="wrapper">
4848
<div class="header">Assignees</div>
4949
<div class="body">
50-
{#each assignees as { alias, id }}
51-
<Badge variant="neutral" size="small">
50+
{#each assignees as { id, alias }}
51+
<div>
5252
<NodeId {baseUrl} nodeId={id} {alias} />
53-
</Badge>
53+
</div>
5454
{:else}
5555
<div class="txt-missing no-assignees">No assignees</div>
5656
{/each}

src/views/repos/Issue.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@
205205
<div
206206
style:margin-top="2rem"
207207
style="display: flex; flex-direction: column; gap: 0.5rem;">
208-
<Assignees {baseUrl} assignees={issue.assignees} />
208+
<Assignees assignees={issue.assignees} {baseUrl} />
209209
<Labels labels={issue.labels} />
210210
<Embeds embeds={uniqueEmbeds} />
211211
</div>
@@ -248,7 +248,7 @@
248248
</div>
249249
</div>
250250
<div class="metadata global-hide-on-medium-desktop-down">
251-
<Assignees {baseUrl} assignees={issue.assignees} />
251+
<Assignees assignees={issue.assignees} {baseUrl} />
252252
<Labels labels={issue.labels} />
253253
<Embeds embeds={uniqueEmbeds} />
254254
</div>

0 commit comments

Comments
 (0)