-
Notifications
You must be signed in to change notification settings - Fork 15
Cameronmorrow1/fence 2577 bump flutter ios to 3240 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
a5f1baf
ded6e8e
7935339
20091ea
1b79fd4
fbf814f
698b090
7aa2f77
a376d4e
1345e32
a5ba124
db3cffa
582634f
54123e6
c6d5a25
a6b27df
0710bcb
3f17a99
1c1ecd4
8a2bf68
7c95984
10fd826
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,7 +69,7 @@ class _MyAppState extends State<MyApp> with WidgetsBindingObserver { | |
| } | ||
|
|
||
| Future<void> initRadar() async { | ||
| Radar.initialize('prj_test_pk_0000000000000000000000000000000000000000'); | ||
| Radar.initialize('prj_test_pk_0000000000000000000000000000000000000000', silentPush: true); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should make this initialize option a typed dictionary / object instead if those exist.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think dart has those, we'd have to make a class
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe we should make a class then, I think if we have more initialize options in the future, or if we want to expose some of the initialize options that we already have, it'll be easier to manage. maybe a non-typed dictionary can also work if we document the available options well within the code.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if we use a class then the class would have to use the same constructor as here. if we make it non-typed we invite user error. |
||
| Radar.setUserId('flutter'); | ||
| Radar.setDescription('Flutter'); | ||
| Radar.setMetadata({'foo': 'bar', 'bax': true, 'qux': 1}); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.