Internal Rework of how the logging is called

Author: Sertion

src/git/file.ts

@@ -25,7 +25,7 @@ export class GitFile {
             );
 
             if (!isOpen) {
-                ErrorHandler.getInstance().logInfo(
+                ErrorHandler.logInfo(
                     `Clearing the file "${
                         this.fileName.fsPath
                     }" from the internal cache`,

src/git/filedummy.ts

@@ -5,7 +5,7 @@ export class GitFileDummy extends GitFile {
     constructor(fileName: string, disposeCallback: () => void) {
         super(fileName, disposeCallback);
         this.startCacheInterval();
-        ErrorHandler.getInstance().logInfo(
+        ErrorHandler.logInfo(
             `Will not try to blame file "${
                 this.fileName.fsPath
             }" as it is outside of the current workspace`,

src/git/filephysical.ts

@@ -140,7 +140,7 @@ export class GitFilePhysical extends GitFile {
         } else {
             StatusBarView.getInstance().stopProgress();
             this.startCacheInterval();
-            ErrorHandler.getInstance().logInfo(
+            ErrorHandler.logInfo(
                 `File "${
                     this.fileName.fsPath
                 }" is not a decendant of a git repository`,
@@ -179,10 +179,10 @@ export class GitFilePhysical extends GitFile {
             this.startCacheInterval();
 
             if (err) {
-                ErrorHandler.getInstance().logError(err);
+                ErrorHandler.logError(err);
                 resolve(GitBlame.blankBlameInfo());
             } else {
-                ErrorHandler.getInstance().logInfo(
+                ErrorHandler.logInfo(
                     `Blamed file "${this.fileName.fsPath}" and found ${
                         Object.keys(blameInfo.commits).length
                     } commits`,

src/git/stream.ts

@@ -29,7 +29,7 @@ export class GitBlameStream extends EventEmitter {
                 cwd: workTree,
             };
 
-            ErrorHandler.getInstance().logCommand(
+            ErrorHandler.logCommand(
                 `${gitCommand} ${args.join(" ")}`,
             );
 

src/util/errorhandler.ts

@@ -11,6 +11,28 @@ enum LogCategory {
 }
 
 export class ErrorHandler {
+    public static logInfo(message: string) {
+        ErrorHandler.getInstance().writeToLog(LogCategory.Info, message);
+    }
+
+    public static logCommand(message: string): void {
+        ErrorHandler.getInstance().writeToLog(LogCategory.Command, message);
+    }
+
+    public static logError(error: Error): void {
+        ErrorHandler.getInstance().writeToLog(
+            LogCategory.Error,
+            error.toString(),
+        );
+    }
+
+    public static logCritical(error: Error, message: string): void {
+        ErrorHandler.getInstance().writeToLog(
+            LogCategory.Critical,
+            error.toString(),
+        );
+        ErrorHandler.getInstance().showErrorMessage(message);
+    }
 
     public static getInstance(): ErrorHandler {
         if (!ErrorHandler.instance) {
@@ -46,23 +68,6 @@ export class ErrorHandler {
         this.outputChannel = window.createOutputChannel("Extension: gitblame");
     }
 
-    public logInfo(message: string) {
-        this.writeToLog(LogCategory.Info, message);
-    }
-
-    public logCommand(message: string): void {
-        this.writeToLog(LogCategory.Command, message);
-    }
-
-    public logError(error: Error): void {
-        this.writeToLog(LogCategory.Error, error.toString());
-    }
-
-    public logCritical(error: Error, message: string): void {
-        this.writeToLog(LogCategory.Critical, error.toString());
-        this.showErrorMessage(message);
-    }
-
     public dispose() {
         this.outputChannel.dispose();
     }

src/util/execcommand.ts

@@ -8,14 +8,14 @@ export function execute(
     options: ExecOptions = {},
 ): Promise<string> {
     return new Promise((resolve, reject) => {
-        ErrorHandler.getInstance().logCommand(`${command} ${args.join(" ")}`);
+        ErrorHandler.logCommand(`${command} ${args.join(" ")}`);
         execFile(
             command,
             args,
             options,
             (error, stdout, stderr) => {
                 if (error) {
-                    ErrorHandler.getInstance().logError(new Error(stderr));
+                    ErrorHandler.logError(new Error(stderr));
                     resolve("");
                 } else {
                     resolve(stdout);

src/util/gitcommand.ts

@@ -18,7 +18,7 @@ export function getGitCommand(): Promise<string> {
 
         access(commandPath, FSConstant.X_OK, (err) => {
             if (err) {
-                ErrorHandler.getInstance().logError(
+                ErrorHandler.logError(
                     new Error(
                         `Can not execute "${
                             commandPath