-
Notifications
You must be signed in to change notification settings - Fork 23
Fixed typo for ResponseCode::PrecoditionFailed
#307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo for ResponseCode::PrecoditionFailed
#307
Conversation
- changed the enum variant for `ResponseCode::PrecoditionFailed` to `ResponseCode::PrecondtionFailed` - Updated conversions (TryFrom<u16> and From<&ResponseCode>) to map to and from this correct variant. - updated tests that implement this enum variant
ResponseCode::PrecoditionFailedResponseCode::PrecoditionFailed
|
@Mpinyaz thank you for your PR. Our company did some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR. The process is explained here in this repo README: https://github.com/rabbitmq/cla Would you review and sign this CLA? |
|
@Gsantomaggio okay no problem yes done signed the CLA |
|
@Gsantomaggio @wolf4ood @allevo if let Some(keys) = binding_keys {
// handle Some case - `keys` is the extracted Vec<String>
new_binding_keys = keys;
} else {
// handle None case
} |
|
@Mpinyaz, please go ahead with the fix. |
#Refactor: Use if let for Option unwrapping in stream_creator Changed binding_keys handling from: - if binding_keys.is_none() + unwrap() To: - if let Some(keys) = binding_keys This is more idiomatic Rust and resolves the clippy unnecessary_unwrap lint error. Additonally refactored the format! specifiers caught by the linter warnings
|
@Gsantomaggio pushed changes to the PR and would like to also take note of the following:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 89.12% 88.95% -0.18%
==========================================
Files 81 81
Lines 7625 7125 -500
==========================================
- Hits 6796 6338 -458
+ Misses 829 787 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you @Mpinyaz |
ResponseCode::PrecoditionFailedtoResponseCode::PreconditionFailedLink to Issue below:
Fix Typo in ResponseCode::PrecoditionFailed #306