Add Producer/Consumer Identifier (#348)

Gsantomaggio · web-flow · commit 85c220a42e01 · 2024-01-23T10:32:25.000+01:00
* Add Producer/Consumer Identifier
   The Identifier helps to correlate the entities with the logs and the UI.
---------
Signed-off-by: Gabriele Santomaggio &lt;G.santomaggio@gmail.com&gt;
diff --git a/RabbitMQ.Stream.Client/AbstractEntity.cs b/RabbitMQ.Stream.Client/AbstractEntity.cs
@@ -13,6 +13,14 @@ public abstract record EntityCommonConfig
     {
         internal ConnectionsPool Pool { get; set; }
         public Func<MetaDataUpdate, Task> MetadataHandler { get; set; }
+
+        /// <summary>
+        /// The Identifier does not have any effect on the server.
+        /// It is used to identify the entity in the logs and on the UI (only for the consumer)
+        /// It is possible to retrieve the entity info using the Info.Identifier method form the
+        /// raw* instances.
+        /// </summary>
+        public string Identifier { get; set; }
     }
 
     internal enum EntityStatus
diff --git a/RabbitMQ.Stream.Client/EntityInfo.cs b/RabbitMQ.Stream.Client/EntityInfo.cs
@@ -6,10 +6,12 @@ namespace RabbitMQ.Stream.Client;
 
 public abstract class Info
 {
+    public string Identifier { get; }
     public string Stream { get; }
 
-    protected Info(string stream)
+    protected Info(string stream, string identifier)
     {
         Stream = stream;
+        Identifier = identifier;
     }
 }
diff --git a/RabbitMQ.Stream.Client/IConsumer.cs b/RabbitMQ.Stream.Client/IConsumer.cs
@@ -80,13 +80,13 @@ public class ConsumerInfo : Info
 {
     public string Reference { get; }
 
-    public ConsumerInfo(string stream, string reference) : base(stream)
+    public ConsumerInfo(string stream, string reference, string identifier) : base(stream, identifier)
     {
         Reference = reference;
     }
 
     public override string ToString()
     {
-        return $"{base.ToString()}, Reference: {Reference}";
+        return $"ConsumerInfo(Stream={Stream}, Reference={Reference}, Identifier={Identifier})";
     }
 }
diff --git a/RabbitMQ.Stream.Client/IProducer.cs b/RabbitMQ.Stream.Client/IProducer.cs
@@ -114,8 +114,13 @@ public class ProducerInfo : Info
 {
     public string Reference { get; }
 
-    public ProducerInfo(string stream, string reference) : base(stream)
+    public ProducerInfo(string stream, string reference, string identifier) : base(stream, identifier)
     {
         Reference = reference;
     }
+
+    public override string ToString()
+    {
+        return $"ProducerInfo(Stream={Stream}, Reference={Reference}, Identifier={Identifier})";
+    }
 }
diff --git a/RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt b/RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt
@@ -7,6 +7,7 @@ const RabbitMQ.Stream.Client.RouteQueryResponse.Key = 24 -> ushort
 const RabbitMQ.Stream.Client.StreamStatsResponse.Key = 28 -> ushort
 override RabbitMQ.Stream.Client.Broker.ToString() -> string
 override RabbitMQ.Stream.Client.ConsumerInfo.ToString() -> string
+override RabbitMQ.Stream.Client.ProducerInfo.ToString() -> string
 override RabbitMQ.Stream.Client.RawConsumer.Close() -> System.Threading.Tasks.Task<RabbitMQ.Stream.Client.ResponseCode>
 override RabbitMQ.Stream.Client.RawProducer.Close() -> System.Threading.Tasks.Task<RabbitMQ.Stream.Client.ResponseCode>
 RabbitMQ.Stream.Client.AbstractEntity.Dispose(bool disposing) -> void
@@ -80,7 +81,7 @@ RabbitMQ.Stream.Client.ConsumerFilter.PostFilter.set -> void
 RabbitMQ.Stream.Client.ConsumerFilter.Values.get -> System.Collections.Generic.List<string>
 RabbitMQ.Stream.Client.ConsumerFilter.Values.set -> void
 RabbitMQ.Stream.Client.ConsumerInfo
-RabbitMQ.Stream.Client.ConsumerInfo.ConsumerInfo(string stream, string reference) -> void
+RabbitMQ.Stream.Client.ConsumerInfo.ConsumerInfo(string stream, string reference, string identifier) -> void
 RabbitMQ.Stream.Client.ConsumerInfo.Reference.get -> string
 RabbitMQ.Stream.Client.CrcException
 RabbitMQ.Stream.Client.CrcException.CrcException(string s) -> void
@@ -92,6 +93,8 @@ RabbitMQ.Stream.Client.CreateException.ResponseCode.get -> RabbitMQ.Stream.Clien
 RabbitMQ.Stream.Client.CreateException.ResponseCode.init -> void
 RabbitMQ.Stream.Client.CreateProducerException.CreateProducerException(string s, RabbitMQ.Stream.Client.ResponseCode responseCode) -> void
 RabbitMQ.Stream.Client.EntityCommonConfig
+RabbitMQ.Stream.Client.EntityCommonConfig.Identifier.get -> string
+RabbitMQ.Stream.Client.EntityCommonConfig.Identifier.set -> void
 RabbitMQ.Stream.Client.EntityCommonConfig.MetadataHandler.get -> System.Func<RabbitMQ.Stream.Client.MetaDataUpdate, System.Threading.Tasks.Task>
 RabbitMQ.Stream.Client.EntityCommonConfig.MetadataHandler.set -> void
 RabbitMQ.Stream.Client.HashRoutingMurmurStrategy.Route(RabbitMQ.Stream.Client.Message message, System.Collections.Generic.List<string> partitions) -> System.Threading.Tasks.Task<System.Collections.Generic.List<string>>
@@ -133,7 +136,8 @@ RabbitMQ.Stream.Client.IConsumerConfig.InitialCredits.set -> void
 RabbitMQ.Stream.Client.ICrc32
 RabbitMQ.Stream.Client.ICrc32.Hash(byte[] data) -> byte[]
 RabbitMQ.Stream.Client.Info
-RabbitMQ.Stream.Client.Info.Info(string stream) -> void
+RabbitMQ.Stream.Client.Info.Identifier.get -> string
+RabbitMQ.Stream.Client.Info.Info(string stream, string identifier) -> void
 RabbitMQ.Stream.Client.Info.Stream.get -> string
 RabbitMQ.Stream.Client.IProducer.Info.get -> RabbitMQ.Stream.Client.ProducerInfo
 RabbitMQ.Stream.Client.IProducerConfig.Filter.get -> RabbitMQ.Stream.Client.ProducerFilter
@@ -154,7 +158,7 @@ RabbitMQ.Stream.Client.ProducerFilter
 RabbitMQ.Stream.Client.ProducerFilter.FilterValue.get -> System.Func<RabbitMQ.Stream.Client.Message, string>
 RabbitMQ.Stream.Client.ProducerFilter.FilterValue.set -> void
 RabbitMQ.Stream.Client.ProducerInfo
-RabbitMQ.Stream.Client.ProducerInfo.ProducerInfo(string stream, string reference) -> void
+RabbitMQ.Stream.Client.ProducerInfo.ProducerInfo(string stream, string reference, string identifier) -> void
 RabbitMQ.Stream.Client.ProducerInfo.Reference.get -> string
 RabbitMQ.Stream.Client.PublishFilter
 RabbitMQ.Stream.Client.PublishFilter.Command.get -> ushort
@@ -205,9 +209,10 @@ RabbitMQ.Stream.Client.Reliable.ProducerConfig.Filter.set -> void
 RabbitMQ.Stream.Client.Reliable.ProducerConfig.Reference.set -> void
 RabbitMQ.Stream.Client.Reliable.ProducerFactory.CreateProducer(bool boot) -> System.Threading.Tasks.Task<RabbitMQ.Stream.Client.IProducer>
 RabbitMQ.Stream.Client.Reliable.ProducerFactory._producer -> RabbitMQ.Stream.Client.IProducer
-RabbitMQ.Stream.Client.Reliable.ReliableBase.CompareStatus(RabbitMQ.Stream.Client.Reliable.ReliableEntityStatus toTest) -> bool
 RabbitMQ.Stream.Client.Reliable.ReliableBase.UpdateStatus(RabbitMQ.Stream.Client.Reliable.ReliableEntityStatus status) -> void
 RabbitMQ.Stream.Client.Reliable.ReliableBase._status -> RabbitMQ.Stream.Client.Reliable.ReliableEntityStatus
+RabbitMQ.Stream.Client.Reliable.ReliableConfig.Identifier.get -> string
+RabbitMQ.Stream.Client.Reliable.ReliableConfig.Identifier.set -> void
 RabbitMQ.Stream.Client.Reliable.ReliableConfig.ReconnectStrategy.get -> RabbitMQ.Stream.Client.Reliable.IReconnectStrategy
 RabbitMQ.Stream.Client.Reliable.ReliableConfig.ResourceAvailableReconnectStrategy.get -> RabbitMQ.Stream.Client.Reliable.IReconnectStrategy
 RabbitMQ.Stream.Client.Reliable.ReliableConfig.ResourceAvailableReconnectStrategy.set -> void
diff --git a/RabbitMQ.Stream.Client/RawConsumer.cs b/RabbitMQ.Stream.Client/RawConsumer.cs
@@ -132,7 +132,9 @@ protected sealed override string DumpEntityConfiguration()
                 ? "No SuperStream"
                 : $"SuperStream {_config.SuperStream}";
             return
-                $"Consumer id {EntityId} for stream: {_config.Stream}, reference: {_config.Reference}, OffsetSpec {_config.OffsetSpec} " +
+                $"Consumer id {EntityId} for stream: {_config.Stream}, " +
+                $"identifier: {_config.Identifier}, " +
+                $"reference: {_config.Reference}, OffsetSpec {_config.OffsetSpec} " +
                 $"Client ProvidedName {_config.ClientProvidedName}, " +
                 $"{superStream}, IsSingleActiveConsumer: {_config.IsSingleActiveConsumer}, " +
                 $"Token IsCancellationRequested: {Token.IsCancellationRequested} ";
@@ -144,7 +146,7 @@ private RawConsumer(Client client, RawConsumerConfig config, ILogger logger = nu
             _initialCredits = config.InitialCredits;
             _config = config;
             Logger.LogDebug("Creating... {DumpEntityConfiguration}", DumpEntityConfiguration());
-            Info = new ConsumerInfo(_config.Stream, _config.Reference);
+            Info = new ConsumerInfo(_config.Stream, _config.Reference, _config.Identifier);
             // _chunksBuffer is a channel that is used to buffer the chunks
             _chunksBuffer = Channel.CreateBounded<Chunk>(new BoundedChannelOptions(_initialCredits)
             {
@@ -483,6 +485,11 @@ private async Task Init()
                 consumerProperties["name"] = _config.Reference;
             }
 
+            if (!string.IsNullOrEmpty(_config.Identifier))
+            {
+                consumerProperties["identifier"] = _config.Identifier;
+            }
+
             if (_config.IsFiltering)
             {
                 var i = 0;
diff --git a/RabbitMQ.Stream.Client/RawProducer.cs b/RabbitMQ.Stream.Client/RawProducer.cs
@@ -60,7 +60,9 @@ public class RawProducer : AbstractEntity, IProducer, IDisposable
         protected sealed override string DumpEntityConfiguration()
         {
             return
-                $"Producer id {EntityId} for stream: {_config.Stream}, reference: {_config.Reference}," +
+                $"Producer id {EntityId} for stream: {_config.Stream}, " +
+                $"identifier: {_config.Identifier}" +
+                $"reference: {_config.Reference}," +
                 $"Client ProvidedName {_config.ClientProvidedName}, " +
                 $"Token IsCancellationRequested: {Token.IsCancellationRequested} ";
         }
@@ -87,7 +89,7 @@ private RawProducer(Client client, RawProducerConfig config, ILogger logger = nu
         {
             _client = client;
             _config = config;
-            Info = new ProducerInfo(_config.Stream, _config.Reference);
+            Info = new ProducerInfo(_config.Stream, _config.Reference, config.Identifier);
             Logger = logger ?? NullLogger.Instance;
             Logger.LogDebug("Creating... {DumpEntityConfiguration}", DumpEntityConfiguration());
             _messageBuffer = Channel.CreateBounded<OutgoingMsg>(new BoundedChannelOptions(10000)
diff --git a/RabbitMQ.Stream.Client/RawSuperStreamConsumer.cs b/RabbitMQ.Stream.Client/RawSuperStreamConsumer.cs
@@ -57,7 +57,7 @@ private RawSuperStreamConsumer(
         _streamInfos = streamInfos;
         _clientParameters = clientParameters;
         _logger = logger ?? NullLogger.Instance;
-        Info = new ConsumerInfo(_config.SuperStream, _config.Reference);
+        Info = new ConsumerInfo(_config.SuperStream, _config.Reference, config.Identifier);
 
         StartConsumers().Wait(CancellationToken.None);
     }
@@ -74,6 +74,7 @@ private RawConsumerConfig FromStreamConfig(string stream)
             ConsumerFilter = _config.ConsumerFilter,
             Pool = _config.Pool,
             Crc32 = _config.Crc32,
+            Identifier = _config.Identifier,
             ConnectionClosedHandler = async (reason) =>
             {
                 _consumers.TryRemove(stream, out var consumer);
@@ -199,8 +200,8 @@ public void Dispose()
     {
         foreach (var stream in _consumers.Keys)
         {
-            _consumers.TryRemove(stream, out var consumer);
-            consumer?.Close();
+            _consumers.TryGetValue(stream, out var consumer);
+            consumer?.Dispose();
         }
 
         _disposed = true;
diff --git a/RabbitMQ.Stream.Client/RawSuperStreamProducer.cs b/RabbitMQ.Stream.Client/RawSuperStreamProducer.cs
@@ -65,7 +65,7 @@ private RawSuperStreamProducer(
         _config = config;
         _streamInfos = streamInfos;
         _clientParameters = clientParameters;
-        Info = new ProducerInfo(config.SuperStream, config.Reference);
+        Info = new ProducerInfo(config.SuperStream, config.Reference, config.Identifier);
         _defaultRoutingConfiguration.RoutingStrategy = _config.RoutingStrategyType switch
         {
             RoutingStrategyType.Key => new KeyRoutingStrategy(_config.Routing,
@@ -92,6 +92,7 @@ private RawProducerConfig FromStreamConfig(string stream)
             MaxInFlight = _config.MaxInFlight,
             Filter = _config.Filter,
             Pool = _config.Pool,
+            Identifier = _config.Identifier,
             ConnectionClosedHandler = async (reason) =>
             {
                 _producers.TryGetValue(stream, out var producer);
diff --git a/RabbitMQ.Stream.Client/Reliable/Consumer.cs b/RabbitMQ.Stream.Client/Reliable/Consumer.cs
@@ -164,7 +164,7 @@ internal Consumer(ConsumerConfig consumerConfig, ILogger<Consumer> logger = null
     {
         _logger = logger ?? NullLogger<Consumer>.Instance;
         _consumerConfig = consumerConfig;
-        Info = new ConsumerInfo(consumerConfig.Stream, consumerConfig.Reference);
+        Info = new ConsumerInfo(consumerConfig.Stream, consumerConfig.Reference, consumerConfig.Identifier);
     }
 
     public static async Task<Consumer> Create(ConsumerConfig consumerConfig, ILogger<Consumer> logger = null)
@@ -215,7 +215,9 @@ public override async Task Close()
 
     public override string ToString()
     {
-        return $"Consumer reference: {_consumerConfig.Reference}, stream: {_consumerConfig.Stream}, " +
+        return $"Consumer reference: {_consumerConfig.Reference}, " +
+               $"stream: {_consumerConfig.Stream}, " +
+               $"identifier: {_consumerConfig.Identifier}, " +
                $"client name: {_consumerConfig.ClientProvidedName} ";
     }
 
diff --git a/RabbitMQ.Stream.Client/Reliable/ConsumerFactory.cs b/RabbitMQ.Stream.Client/Reliable/ConsumerFactory.cs
@@ -57,6 +57,7 @@ private async Task<IConsumer> StandardConsumer(bool boot)
             OffsetSpec = offsetSpec,
             ConsumerFilter = _consumerConfig.Filter,
             Crc32 = _consumerConfig.Crc32,
+            Identifier = _consumerConfig.Identifier,
             ConnectionClosedHandler = async (closeReason) =>
             {
                 if (closeReason == ConnectionClosedReason.Normal)
@@ -120,6 +121,7 @@ private async Task<IConsumer> SuperConsumer(bool boot)
                     ConsumerFilter = _consumerConfig.Filter,
                     Crc32 = _consumerConfig.Crc32,
                     OffsetSpec = offsetSpecs,
+                    Identifier = _consumerConfig.Identifier,
                     ConnectionClosedHandler = async (closeReason, partitionStream) =>
                     {
                         await RandomWait().ConfigureAwait(false);
diff --git a/RabbitMQ.Stream.Client/Reliable/Producer.cs b/RabbitMQ.Stream.Client/Reliable/Producer.cs
@@ -124,7 +124,6 @@ public ProducerConfig(StreamSystem streamSystem, string stream) : base(streamSys
 /// </summary>
 public class Producer : ProducerFactory
 {
-
     private ulong _publishingId;
     private readonly ILogger<Producer> _logger;
 
@@ -138,7 +137,7 @@ private Producer(ProducerConfig producerConfig, ILogger<Producer> logger = null)
             producerConfig.TimeoutMessageAfter,
             producerConfig.MaxInFlight
         );
-        Info = new ProducerInfo(producerConfig.Stream, producerConfig.Reference);
+        Info = new ProducerInfo(producerConfig.Stream, producerConfig.Reference, producerConfig.Identifier);
         _logger = logger ?? NullLogger<Producer>.Instance;
     }
 
@@ -336,7 +335,9 @@ public async ValueTask Send(List<Message> messages, CompressionType compressionT
 
     public override string ToString()
     {
-        return $"Producer stream: {_producerConfig.Stream}, client name: {_producerConfig.ClientProvidedName}";
+        return $"Producer stream: {_producerConfig.Stream}, " +
+               $"identifier: {_producerConfig.Identifier}, " +
+               $"client name: {_producerConfig.ClientProvidedName}";
     }
 
     /// <summary>
diff --git a/RabbitMQ.Stream.Client/Reliable/ProducerFactory.cs b/RabbitMQ.Stream.Client/Reliable/ProducerFactory.cs
@@ -45,6 +45,7 @@ private async Task<IProducer> SuperStreamProducer(bool boot)
                     Routing = _producerConfig.SuperStreamConfig.Routing,
                     RoutingStrategyType = _producerConfig.SuperStreamConfig.RoutingStrategyType,
                     Filter = _producerConfig.Filter,
+                    Identifier = _producerConfig.Identifier,
                     ConnectionClosedHandler = async (closeReason, partitionStream) =>
                     {
                         await RandomWait().ConfigureAwait(false);
@@ -99,6 +100,7 @@ private async Task<IProducer> StandardProducer()
             Reference = _producerConfig.Reference,
             MaxInFlight = _producerConfig.MaxInFlight,
             Filter = _producerConfig.Filter,
+            Identifier = _producerConfig.Identifier,
             MetadataHandler = async _ =>
             {
                 await RandomWait().ConfigureAwait(false);
diff --git a/RabbitMQ.Stream.Client/Reliable/ReliableBase.cs b/RabbitMQ.Stream.Client/Reliable/ReliableBase.cs
@@ -11,9 +11,27 @@ namespace RabbitMQ.Stream.Client.Reliable;
 
 public record ReliableConfig
 {
+    /// <summary>
+    /// The interface to reconnect the entity to the server.
+    /// By default it uses a BackOff pattern. See <see cref="BackOffReconnectStrategy"/>
+    /// </summary>
     public IReconnectStrategy ReconnectStrategy { get; set; }
+
+    /// <summary>
+    /// The interface to check if the resource is available.
+    /// A stream could be not fully ready during the restarting.
+    /// By default it uses a BackOff pattern. See <see cref="ResourceAvailableBackOffReconnectStrategy"/>
+    /// </summary>
     public IReconnectStrategy ResourceAvailableReconnectStrategy { get; set; }
 
+    /// <summary>
+    /// The Identifier does not have any effect on the server.
+    /// It is used to identify the entity in the logs and on the UI (only for the consumer)
+    /// It is possible to retrieve the entity info using the Info.Identifier method form the
+    /// Producer/Consumer instances.
+    /// </summary>
+    public string Identifier { get; set; }
+
     public StreamSystem StreamSystem { get; }
     public string Stream { get; }
 
@@ -31,12 +49,15 @@ protected ReliableConfig(StreamSystem streamSystem, string stream)
     }
 }
 
+/// <summary>
+/// The ReliableEntityStatus is used to check the status of the ReliableEntity.
+/// </summary>
 public enum ReliableEntityStatus
 {
-    Initialization,
-    Open,
-    Reconnecting,
-    Closed,
+    Initialization,// the entity is initializing
+    Open, // the entity is open and ready to use
+    Reconnecting,// the entity is reconnecting but still can be used
+    Closed,// the entity is closed and cannot be used anymore
 }
 
 /// <summary>
@@ -62,7 +83,7 @@ protected void UpdateStatus(ReliableEntityStatus status)
         }
     }
 
-    protected bool CompareStatus(ReliableEntityStatus toTest)
+    private bool CompareStatus(ReliableEntityStatus toTest)
     {
         lock (_lock)
         {
diff --git a/RabbitMQ.Stream.Client/StreamSystem.cs b/RabbitMQ.Stream.Client/StreamSystem.cs
diff --git a/Tests/RawConsumerSystemTests.cs b/Tests/RawConsumerSystemTests.cs
diff --git a/Tests/ReliableTests.cs b/Tests/ReliableTests.cs
diff --git a/Tests/SuperStreamConsumerTests.cs b/Tests/SuperStreamConsumerTests.cs
diff --git a/Tests/SuperStreamProducerTests.cs b/Tests/SuperStreamProducerTests.cs

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,14 @@ public abstract record EntityCommonConfig`
`13`	`13`	`{`
`14`	`14`	`internal ConnectionsPool Pool { get; set; }`
`15`	`15`	`public Func<MetaDataUpdate, Task> MetadataHandler { get; set; }`
	`16`	`+`
	`17`	`+ /// <summary>`
	`18`	`+ /// The Identifier does not have any effect on the server.`
	`19`	`+ /// It is used to identify the entity in the logs and on the UI (only for the consumer)`
	`20`	`+ /// It is possible to retrieve the entity info using the Info.Identifier method form the`
	`21`	`+ /// raw* instances.`
	`22`	`+ /// </summary>`
	`23`	`+ public string Identifier { get; set; }`
`16`	`24`	`}`
`17`	`25`
`18`	`26`	`internal enum EntityStatus`
Original file line number	Diff line number	Diff line change
`@@ -6,10 +6,12 @@ namespace RabbitMQ.Stream.Client;`
`6`	`6`
`7`	`7`	`public abstract class Info`
`8`	`8`	`{`
	`9`	`+ public string Identifier { get; }`
`9`	`10`	`public string Stream { get; }`
`10`	`11`
`11`		`- protected Info(string stream)`
	`12`	`+ protected Info(string stream, string identifier)`
`12`	`13`	`{`
`13`	`14`	`Stream = stream;`
	`15`	`+ Identifier = identifier;`
`14`	`16`	`}`
`15`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,13 +80,13 @@ public class ConsumerInfo : Info`
`80`	`80`	`{`
`81`	`81`	`public string Reference { get; }`
`82`	`82`
`83`		`- public ConsumerInfo(string stream, string reference) : base(stream)`
	`83`	`+ public ConsumerInfo(string stream, string reference, string identifier) : base(stream, identifier)`
`84`	`84`	`{`
`85`	`85`	`Reference = reference;`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`public override string ToString()`
`89`	`89`	`{`
`90`		`- return $"{base.ToString()}, Reference: {Reference}";`
	`90`	`+ return $"ConsumerInfo(Stream={Stream}, Reference={Reference}, Identifier={Identifier})";`
`91`	`91`	`}`
`92`	`92`	`}`
Original file line number	Diff line number	Diff line change
`@@ -114,8 +114,13 @@ public class ProducerInfo : Info`
`114`	`114`	`{`
`115`	`115`	`public string Reference { get; }`
`116`	`116`
`117`		`- public ProducerInfo(string stream, string reference) : base(stream)`
	`117`	`+ public ProducerInfo(string stream, string reference, string identifier) : base(stream, identifier)`
`118`	`118`	`{`
`119`	`119`	`Reference = reference;`
`120`	`120`	`}`
	`121`	`+`
	`122`	`+ public override string ToString()`
	`123`	`+ {`
	`124`	`+ return $"ProducerInfo(Stream={Stream}, Reference={Reference}, Identifier={Identifier})";`
	`125`	`+ }`
`121`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,9 @@ public class RawProducer : AbstractEntity, IProducer, IDisposable`
`60`	`60`	`protected sealed override string DumpEntityConfiguration()`
`61`	`61`	`{`
`62`	`62`	`return`
`63`		`- $"Producer id {EntityId} for stream: {_config.Stream}, reference: {_config.Reference}," +`
	`63`	`+ $"Producer id {EntityId} for stream: {_config.Stream}, " +`
	`64`	`+ $"identifier: {_config.Identifier}" +`
	`65`	`+ $"reference: {_config.Reference}," +`
`64`	`66`	`$"Client ProvidedName {_config.ClientProvidedName}, " +`
`65`	`67`	`$"Token IsCancellationRequested: {Token.IsCancellationRequested} ";`
`66`	`68`	`}`
`@@ -87,7 +89,7 @@ private RawProducer(Client client, RawProducerConfig config, ILogger logger = nu`
`87`	`89`	`{`
`88`	`90`	`_client = client;`
`89`	`91`	`_config = config;`
`90`		`- Info = new ProducerInfo(_config.Stream, _config.Reference);`
	`92`	`+ Info = new ProducerInfo(_config.Stream, _config.Reference, config.Identifier);`
`91`	`93`	`Logger = logger ?? NullLogger.Instance;`
`92`	`94`	`Logger.LogDebug("Creating... {DumpEntityConfiguration}", DumpEntityConfiguration());`
`93`	`95`	`_messageBuffer = Channel.CreateBounded<OutgoingMsg>(new BoundedChannelOptions(10000)`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ private RawSuperStreamConsumer(`
`57`	`57`	`_streamInfos = streamInfos;`
`58`	`58`	`_clientParameters = clientParameters;`
`59`	`59`	`_logger = logger ?? NullLogger.Instance;`
`60`		`- Info = new ConsumerInfo(_config.SuperStream, _config.Reference);`
	`60`	`+ Info = new ConsumerInfo(_config.SuperStream, _config.Reference, config.Identifier);`
`61`	`61`
`62`	`62`	`StartConsumers().Wait(CancellationToken.None);`
`63`	`63`	`}`
`@@ -74,6 +74,7 @@ private RawConsumerConfig FromStreamConfig(string stream)`
`74`	`74`	`ConsumerFilter = _config.ConsumerFilter,`
`75`	`75`	`Pool = _config.Pool,`
`76`	`76`	`Crc32 = _config.Crc32,`
	`77`	`+ Identifier = _config.Identifier,`
`77`	`78`	`ConnectionClosedHandler = async (reason) =>`
`78`	`79`	`{`
`79`	`80`	`_consumers.TryRemove(stream, out var consumer);`
`@@ -199,8 +200,8 @@ public void Dispose()`
`199`	`200`	`{`
`200`	`201`	`foreach (var stream in _consumers.Keys)`
`201`	`202`	`{`
`202`		`- _consumers.TryRemove(stream, out var consumer);`
`203`		`- consumer?.Close();`
	`203`	`+ _consumers.TryGetValue(stream, out var consumer);`
	`204`	`+ consumer?.Dispose();`
`204`	`205`	`}`
`205`	`206`
`206`	`207`	`_disposed = true;`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ internal Consumer(ConsumerConfig consumerConfig, ILogger<Consumer> logger = null`
`164`	`164`	`{`
`165`	`165`	`_logger = logger ?? NullLogger<Consumer>.Instance;`
`166`	`166`	`_consumerConfig = consumerConfig;`
`167`		`- Info = new ConsumerInfo(consumerConfig.Stream, consumerConfig.Reference);`
	`167`	`+ Info = new ConsumerInfo(consumerConfig.Stream, consumerConfig.Reference, consumerConfig.Identifier);`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`public static async Task<Consumer> Create(ConsumerConfig consumerConfig, ILogger<Consumer> logger = null)`
`@@ -215,7 +215,9 @@ public override async Task Close()`
`215`	`215`
`216`	`216`	`public override string ToString()`
`217`	`217`	`{`
`218`		`- return $"Consumer reference: {_consumerConfig.Reference}, stream: {_consumerConfig.Stream}, " +`
	`218`	`+ return $"Consumer reference: {_consumerConfig.Reference}, " +`
	`219`	`+ $"stream: {_consumerConfig.Stream}, " +`
	`220`	`+ $"identifier: {_consumerConfig.Identifier}, " +`
`219`	`221`	`$"client name: {_consumerConfig.ClientProvidedName} ";`
`220`	`222`	`}`
`221`	`223`