#354 | add unit tests for publishing acks, nacks and unrouted

Author: slayful

src/test/java/com/rabbitmq/client/test/MetricsCollectorTest.java

@@ -147,6 +147,66 @@ public void basicGetAndAck() {
         metrics.cleanStaleState();
         assertThat(failedToPublishMessages(metrics), is(2L));
         assertThat(publishedMessages(metrics), is(2L));
+
+        long anyDeliveryTag = 123L;
+        metrics.basicNack(channel, anyDeliveryTag);
+    }
+
+
+    @Test public void publishingAcknowledgements() {
+        long anyDeliveryTag = 123L;
+        AbstractMetricsCollector metrics = factory.create();
+        Channel channel = mock(Channel.class);
+        // begins with no messages acknowledged
+        assertThat(publishAck(metrics), is(0));
+        // first acknowledgement gets tracked
+        metrics.basicPublishAck(channel, anyDeliveryTag, false);
+        assertThat(publishAck(metrics), is(1));
+        // second acknowledgement gets tracked
+        metrics.basicPublishAck(channel, anyDeliveryTag, false);
+        assertThat(publishAck(metrics), is(2));
+        // multiple deliveries aren't tracked
+        metrics.basicPublishAck(channel, anyDeliveryTag, true);
+        assertThat(publishAck(metrics), is(2));
+        // cleaning stale state doesn't affect the metric
+        metrics.cleanStaleState();
+        assertThat(publishAck(metrics), is(2));
+    }
+
+    @Test public void publishingNotAcknowledgements() {
+        long anyDeliveryTag = 123L;
+        AbstractMetricsCollector metrics = factory.create();
+        Channel channel = mock(Channel.class);
+        // begins with no messages not-acknowledged
+        assertThat(publishNack(metrics), is(0));
+        // first not-acknowledgement gets tracked
+        metrics.basicPublishNack(channel, anyDeliveryTag, false);
+        assertThat(publishNack(metrics), is(1));
+        // second not-acknowledgement gets tracked
+        metrics.basicPublishNack(channel, anyDeliveryTag, false);
+        assertThat(publishNack(metrics), is(2));
+        // multiple deliveries aren't tracked
+        metrics.basicPublishNack(channel, anyDeliveryTag, true);
+        assertThat(publishNack(metrics), is(2));
+        // cleaning stale state doesn't affect the metric
+        metrics.cleanStaleState();
+        assertThat(publishNack(metrics), is(2));
+    }
+
+    @Test public void publishingUnrouted() {
+        AbstractMetricsCollector metrics = factory.create();
+        Channel channel = mock(Channel.class);
+        // begins with no messages not-acknowledged
+        assertThat(publishUnrouted(metrics), is(0));
+        // first unrouted gets tracked
+        metrics.basicPublishUnrouted(channel);
+        assertThat(publishUnrouted(metrics), is(1));
+        // second unrouted gets tracked
+        metrics.basicPublishUnrouted(channel);
+        assertThat(publishUnrouted(metrics), is(2));
+        // cleaning stale state doesn't affect the metric
+        metrics.cleanStaleState();
+        assertThat(publishUnrouted(metrics), is(2));
     }
 
     @Test public void cleanStaleState() {
@@ -189,6 +249,31 @@ public void basicGetAndAck() {
         assertThat(channels(metrics), is(1L));
     }
 
+
+    long publishAck(MetricsCollector metrics) {
+        if (metrics instanceof StandardMetricsCollector) {
+            return ((StandardMetricsCollector) metrics).getPublishAcknowledgedMessages().getCount();
+        } else {
+            return (long) ((MicrometerMetricsCollector) metrics).getAckedPublishedMessages().count();
+        }
+    }
+
+    long publishNack(MetricsCollector metrics) {
+        if (metrics instanceof StandardMetricsCollector) {
+            return ((StandardMetricsCollector) metrics).getPublishNotAcknowledgedMessages().getCount();
+        } else {
+            return (long) ((MicrometerMetricsCollector) metrics).getNackedPublishedMessages().count();
+        }
+    }
+
+    long publishUnrouted(MetricsCollector metrics) {
+        if (metrics instanceof StandardMetricsCollector) {
+            return ((StandardMetricsCollector) metrics).getPublishUnroutedMessages().getCount();
+        } else {
+            return (long) ((MicrometerMetricsCollector) metrics).getUnroutedPublishedMessages().count();
+        }
+    }
+
     long publishedMessages(MetricsCollector metrics) {
         if (metrics instanceof StandardMetricsCollector) {
             return ((StandardMetricsCollector) metrics).getPublishedMessages().getCount();