Naming

Author: michaelklishin

src/main/java/com/rabbitmq/client/ConnectionFactory.java

@@ -132,7 +132,7 @@ public class ConnectionFactory implements Cloneable {
      * Default is false.
      * @since 4.2.0
      */
-    private boolean channelCheckRpcReplyType = false;
+    private boolean channelShouldCheckRpcResponseType = false;
 
     /** @return the default host to use for connections */
     public String getHost() {
@@ -965,7 +965,7 @@ public ConnectionParams params(ExecutorService consumerWorkServiceExecutor) {
         result.setShutdownExecutor(shutdownExecutor);
         result.setHeartbeatExecutor(heartbeatExecutor);
         result.setChannelRpcTimeout(channelRpcTimeout);
-        result.setChannelShouldCheckRpcResponseType(channelCheckRpcReplyType);
+        result.setChannelShouldCheckRpcResponseType(channelShouldCheckRpcResponseType);
         return result;
     }
 
@@ -1136,13 +1136,13 @@ public int getChannelRpcTimeout() {
     /**
      * Set whether or not channels check the reply type of an RPC call.
      * Default is false.
-     * @param channelCheckRpcReplyType
+     * @param channelShouldCheckRpcResponseType
      */
-    public void setChannelCheckRpcReplyType(boolean channelCheckRpcReplyType) {
-        this.channelCheckRpcReplyType = channelCheckRpcReplyType;
+    public void setChannelShouldCheckRpcResponseType(boolean channelShouldCheckRpcResponseType) {
+        this.channelShouldCheckRpcResponseType = channelShouldCheckRpcResponseType;
     }
 
-    public boolean isChannelCheckRpcReplyType() {
-        return channelCheckRpcReplyType;
+    public boolean isChannelShouldCheckRpcResponseType() {
+        return channelShouldCheckRpcResponseType;
     }
 }

src/main/java/com/rabbitmq/client/impl/AMQChannel.java

@@ -71,7 +71,7 @@ public abstract class AMQChannel extends ShutdownNotifierComponent {
     /** Timeout for RPC calls */
     protected final int _rpcTimeout;
 
-    private final boolean _checkRpcReplyType;
+    private final boolean _checkRpcResponseType;
 
     /**
      * Construct a channel on the given connection, with the given channel number.
@@ -85,7 +85,7 @@ public AMQChannel(AMQConnection connection, int channelNumber) {
             throw new IllegalArgumentException("Continuation timeout on RPC calls cannot be less than 0");
         }
         this._rpcTimeout = connection.getChannelRpcTimeout();
-        this._checkRpcReplyType = connection.willCheckRpcResponseType();
+        this._checkRpcResponseType = connection.willCheckRpcResponseType();
     }
 
     /**
@@ -162,7 +162,7 @@ public void handleCompleteInboundCommand(AMQCommand command) throws IOException
         if (!processAsync(command)) {
             // The filter decided not to handle/consume the command,
             // so it must be some reply to an earlier RPC.
-            if (_checkRpcReplyType) {
+            if (_checkRpcResponseType) {
                 synchronized (_channelMutex) {
                     // check if this reply command is intended for the current waiting request before calling nextOutstandingRpc()
                     if (!_activeRpc.canHandleReply(command)) {