Comparison of RabbitMQ.Client.Impl.WireFormatting and ValueReader.java and ValueWriter.java shows that the only missing check in the Java client is the check on writing out a shortstr. Fixed. Also, one grammar mistake.

Author: Matthew Sackman

src/com/rabbitmq/client/impl/ValueWriter.java

@@ -59,6 +59,12 @@ public final void writeShortstr(String str)
         throws IOException
     {
         byte [] bytes = str.getBytes("utf-8");
+        int length = bytes.length;
+        if (length > 255) {
+            throw new IllegalArgumentException(
+                    "Short string too long; utf-8 encoded length = " + length +
+                    ", max = 255."); 
+        }
         out.writeByte(bytes.length);
         out.write(bytes);
     }
@@ -91,7 +97,7 @@ public final void writeShort(int s)
     public final void writeLong(int l)
         throws IOException
     {
-        // java's arithmetic on this type is signed, however its
+        // java's arithmetic on this type is signed, however it's
         // reasonable to use ints to represent the unsigned long
         // type - for values < Integer.MAX_VALUE everything works
         // as expected