simpler way to test confirmSelect idempotence

rade · rade · commit 95fdacaa9196 · 2011-07-08T12:40:55.000+01:00
diff --git a/test/src/com/rabbitmq/client/test/functional/Confirm.java b/test/src/com/rabbitmq/client/test/functional/Confirm.java
@@ -187,6 +187,7 @@ public void testBasicRecover()
     public void testSelect()
         throws IOException
     {
+        channel.confirmSelect();
         try {
             Channel ch = connection.createChannel();
             ch.confirmSelect();
@@ -203,9 +204,6 @@ public void testSelect()
         } catch (IOException ioe) {
             checkShutdownSignal(AMQP.PRECONDITION_FAILED, ioe);
         }
-        Channel ch = connection.createChannel();
-        ch.confirmSelect();
-        ch.confirmSelect();
     }
 
     /* Publish NUM_MESSAGES messages and wait for confirmations. */

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,7 @@ public void testBasicRecover()`
`187`	`187`	`public void testSelect()`
`188`	`188`	`throws IOException`
`189`	`189`	`{`
	`190`	`+ channel.confirmSelect();`
`190`	`191`	`try {`
`191`	`192`	`Channel ch = connection.createChannel();`
`192`	`193`	`ch.confirmSelect();`
`@@ -203,9 +204,6 @@ public void testSelect()`
`203`	`204`	`} catch (IOException ioe) {`
`204`	`205`	`checkShutdownSignal(AMQP.PRECONDITION_FAILED, ioe);`
`205`	`206`	`}`
`206`		`- Channel ch = connection.createChannel();`
`207`		`- ch.confirmSelect();`
`208`		`- ch.confirmSelect();`
`209`	`207`	`}`
`210`	`208`
`211`	`209`	`/* Publish NUM_MESSAGES messages and wait for confirmations. */`