Skip to content

Commit 61f969e

Browse files
committed
Make create/releaseResources nonabstract in base class
1 parent db0c1ee commit 61f969e

File tree

4 files changed

+7
-14
lines changed

4 files changed

+7
-14
lines changed

test/src/com/rabbitmq/client/test/Bug19219Test.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ public class Bug19219Test extends BrokerTestCase {
6363
private static final Semaphore init = new Semaphore(0);
6464
private static final CountDownLatch resume = new CountDownLatch(1);
6565

66-
protected void createResources() throws IOException {}
67-
protected void releaseResources() throws IOException {}
68-
6966
public static TestSuite suite() {
7067
TestSuite suite = new TestSuite("Bug19219");
7168
suite.addTestSuite(Bug19219Test.class);

test/src/com/rabbitmq/client/test/functional/BrokerTestCase.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import com.rabbitmq.client.Connection;
3535
import com.rabbitmq.client.ConnectionFactory;
3636

37-
public abstract class BrokerTestCase extends TestCase
37+
public class BrokerTestCase extends TestCase
3838
{
3939
public ConnectionFactory connectionFactory = new ConnectionFactory();
4040

@@ -69,8 +69,9 @@ protected void tearDown()
6969
* called by BrokerTestCase's implementation of setUp, after the
7070
* connection and channel have been opened.
7171
*/
72-
protected abstract void createResources()
73-
throws IOException;
72+
protected void createResources()
73+
throws IOException
74+
{}
7475

7576
/**
7677
* Should destroy any AMQP resources that were created by the
@@ -79,8 +80,9 @@ protected abstract void createResources()
7980
* reopened specifically for this method. After this method
8081
* completes, the connection and channel will be closed again.
8182
*/
82-
protected abstract void releaseResources()
83-
throws IOException;
83+
protected void releaseResources()
84+
throws IOException
85+
{}
8486

8587
public void openConnection()
8688
throws IOException

test/src/com/rabbitmq/client/test/functional/PersisterRestartBase.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ public class PersisterRestartBase extends BrokerTestCase
4848
// rabbit_persister.erl
4949
protected final int PERSISTER_SNAPSHOT_THRESHOLD = 500;
5050

51-
protected void createResources() throws IOException {}
52-
protected void releaseResources() throws IOException {}
53-
5451
protected void restart()
5552
throws IOException
5653
{

test/src/com/rabbitmq/client/test/functional/RequeueOnClose.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ protected void tearDown()
5454
// Override to disable the default behaviour from BrokerTestCase.
5555
}
5656

57-
protected void createResources() throws IOException {}
58-
protected void releaseResources() throws IOException {}
59-
6057
public void injectMessage()
6158
throws IOException
6259
{

0 commit comments

Comments
 (0)