Skip to content

Commit 5bff5dd

Browse files
committed
#354 | ignore acks and nacks for multiple messages
Metrics for multiple acks and nacks are unsupported in this naive approach.
1 parent 704fa1e commit 5bff5dd

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/main/java/com/rabbitmq/client/impl/AbstractMetricsCollector.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,10 @@ public void basicPublishFailure(Channel channel, Throwable cause) {
113113

114114
@Override
115115
public void basicPublishAck(Channel channel, long deliveryTag, boolean multiple) {
116+
if (multiple) {
117+
// this is a naive approach, as it does not handle multiple nacks
118+
return;
119+
}
116120
try {
117121
markMessagePublishAcknowledged();
118122
} catch(Exception e) {
@@ -122,6 +126,10 @@ public void basicPublishAck(Channel channel, long deliveryTag, boolean multiple)
122126

123127
@Override
124128
public void basicPublishNack(Channel channel, long deliveryTag, boolean multiple) {
129+
if (multiple) {
130+
// this is a naive approach, as it does not handle multiple nacks
131+
return;
132+
}
125133
try {
126134
markMessagePublishNotAcknowledged();
127135
} catch(Exception e) {

0 commit comments

Comments
 (0)