Creating a new channel from a connection that had one of its channel shutdown due to protocol violation, throws TaskCanceled exception

[arunprakashn]

Describe the bug

Dotnet Nuget Version 7.1.2

• Create a connection
• Create 5 channels from the connection
• Create consumers and start listening
• For testing purposes, use a random number as the delivery tag and Ack it
• The channel shutdown stating protocol violation due to invalid delivery tag
• In the shutdown event, handle this situation and then use the same connection that we first created to create another fresh channel.
• This throws TaskCanceled Exception
• Note that the connection..IsOpen is true which indicates the connection is good
• The other 4 channels continue to work and receive messages which further reinforces that the connection is good

Is this by design, that a connection which had had one of its channel shutdown due to a protocol violation cannot be used for new channel creation?

Exception details:

at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) in System.Runtime.CompilerServices\TaskAwaiter.cs:line 107
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) in System.Runtime.CompilerServices\TaskAwaiter.cs:line 88
   at RabbitMQ.Client.Impl.Channel.<OpenAsync>d__80.MoveNext() in /_/projects/RabbitMQ.Client/Impl/Channel.cs:line 399
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() in System.Runtime.ExceptionServices\ExceptionDispatchInfo.cs:line 72
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) in System.Runtime.CompilerServices\TaskAwaiter.cs:line 107
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) in System.Runtime.CompilerServices\TaskAwaiter.cs:line 88

Reproduction steps

Dotnet Nuget Version 7.1.2

• Create a connection
• Create 5 channels from the connection
• Create consumers and start listening
• For testing purposes, use a random number as the delivery tag and Ack it
• The channel shutdown stating protocol violation due to invalid delivery tag
• In the shutdown event, handle this situation and then use the same connection that we first created to create another fresh channel.
• This throws TaskCanceled Exception
• Note that the connection..IsOpen is true which indicates the connection is good
• The other 4 channels continue to work and receive messages which further reinforces that the connection is good

Is this by design, that a connection which had had one of its channel shutdown due to a protocol violation cannot be used for new channel creation?

Expected behavior

I think the new channel should have been created

Additional context

No response

[michaelklishin]

You are not supposed to be opening new channels from a shutdown callback.

[lukebakken]

I agree with @michaelklishin but I would also like to investigate this a little.

@arunprakashn please provide code that I can compile and run to observe this behavior. Basically, this is all that I should have to do:

git clone https://github.com/arunprakashn/rabbitmq-dotnet-client-1879.git
cd rabbitmq-dotnet-client-1879
dotnet run

Thanks