* Make conversion from ConsumerTag to string explicit

* Replace `string` with `ConsumerTag`

Author: lukebakken

projects/Benchmarks/ConsumerDispatching/AsyncBasicConsumerFake.cs

@@ -18,7 +18,8 @@ public AsyncBasicConsumerFake(ManualResetEventSlim autoResetEvent)
             _autoResetEvent = autoResetEvent;
         }
 
-        public Task HandleBasicDeliver(string consumerTag, ulong deliveryTag, bool redelivered, ReadOnlyMemory<byte> exchange, ReadOnlyMemory<byte> routingKey,
+        public Task HandleBasicDeliver(ConsumerTag consumerTag, ulong deliveryTag, bool redelivered,
+            ExchangeName exchange, RoutingKey routingKey,
             in ReadOnlyBasicProperties properties, ReadOnlyMemory<byte> body)
         {
             if (Interlocked.Increment(ref _current) == Count)
@@ -29,7 +30,8 @@ public Task HandleBasicDeliver(string consumerTag, ulong deliveryTag, bool redel
             return Task.CompletedTask;
         }
 
-        Task IBasicConsumer.HandleBasicDeliverAsync(string consumerTag, ulong deliveryTag, bool redelivered, ReadOnlyMemory<byte> exchange, ReadOnlyMemory<byte> routingKey,
+        Task IBasicConsumer.HandleBasicDeliverAsync(ConsumerTag consumerTag, ulong deliveryTag, bool redelivered,
+            ExchangeName exchange, RoutingKey routingKey,
             ReadOnlyBasicProperties properties, ReadOnlyMemory<byte> body)
         {
             if (Interlocked.Increment(ref _current) == Count)
@@ -40,11 +42,11 @@ Task IBasicConsumer.HandleBasicDeliverAsync(string consumerTag, ulong deliveryTa
             return Task.CompletedTask;
         }
 
-        public Task HandleBasicCancel(string consumerTag) => Task.CompletedTask;
+        public Task HandleBasicCancel(ConsumerTag consumerTag) => Task.CompletedTask;
 
-        public Task HandleBasicCancelOk(string consumerTag) => Task.CompletedTask;
+        public Task HandleBasicCancelOk(ConsumerTag consumerTag) => Task.CompletedTask;
 
-        public Task HandleBasicConsumeOk(string consumerTag) => Task.CompletedTask;
+        public Task HandleBasicConsumeOk(ConsumerTag consumerTag) => Task.CompletedTask;
 
         public Task HandleChannelShutdown(object channel, ShutdownEventArgs reason) => Task.CompletedTask;
 
@@ -62,19 +64,19 @@ public event AsyncEventHandler<ConsumerEventArgs> ConsumerCancelled
             remove { }
         }
 
-        void IBasicConsumer.HandleBasicCancelOk(string consumerTag)
+        void IBasicConsumer.HandleBasicCancelOk(ConsumerTag consumerTag)
         {
         }
 
-        void IBasicConsumer.HandleBasicConsumeOk(string consumerTag)
+        void IBasicConsumer.HandleBasicConsumeOk(ConsumerTag consumerTag)
         {
         }
 
         void IBasicConsumer.HandleChannelShutdown(object channel, ShutdownEventArgs reason)
         {
         }
 
-        void IBasicConsumer.HandleBasicCancel(string consumerTag)
+        void IBasicConsumer.HandleBasicCancel(ConsumerTag consumerTag)
         {
         }
     }

projects/Benchmarks/ConsumerDispatching/ConsumerDispatcher.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;
@@ -16,11 +15,12 @@ public class ConsumerDispatcherBase
 
         private protected IConsumerDispatcher _dispatcher;
         private protected readonly AsyncBasicConsumerFake _consumer = new AsyncBasicConsumerFake(_autoResetEvent);
-        protected readonly string _consumerTag = "ConsumerTag";
-        protected static readonly byte[] _consumerTagBytes = Encoding.UTF8.GetBytes("ConsumerTag");
+
+        protected static readonly ConsumerTag _consumerTag = new ConsumerTag("ConsumerTag");
+        protected static readonly ExchangeName _exchange = new ExchangeName("Exchange");
+        protected static readonly RoutingKey _routingKey = new RoutingKey("RoutingKey");
+
         protected readonly ulong _deliveryTag = 500UL;
-        protected static readonly byte[] _exchange = Encoding.UTF8.GetBytes("Exchange");
-        protected static readonly byte[] _routingKey = Encoding.UTF8.GetBytes("RoutingKey");
         protected readonly ReadOnlyBasicProperties _properties = new ReadOnlyBasicProperties();
         protected readonly byte[] _method = new byte[512];
         protected readonly byte[] _body = new byte[512];
@@ -55,7 +55,7 @@ public async Task AsyncConsumerDispatcher()
             {
                 for (int i = 0; i < Count; i++)
                 {
-                    await _dispatcher.HandleBasicDeliverAsync(_consumerTagBytes, _deliveryTag,
+                    await _dispatcher.HandleBasicDeliverAsync(_consumerTag, _deliveryTag,
                         false, _exchange, _routingKey, _properties, body, CancellationToken.None);
                 }
                 _autoResetEvent.Wait();
@@ -78,7 +78,7 @@ public async Task ConsumerDispatcher()
             {
                 for (int i = 0; i < Count; i++)
                 {
-                    await _dispatcher.HandleBasicDeliverAsync(_consumerTagBytes, _deliveryTag,
+                    await _dispatcher.HandleBasicDeliverAsync(_consumerTag, _deliveryTag,
                         false, _exchange, _routingKey, _properties, body, CancellationToken.None);
                 }
                 _autoResetEvent.Wait();