Make connection implement IAsyncDisposable

Author: danielmarbach

projects/RabbitMQ.Client/IConnection.cs

@@ -50,12 +50,12 @@ namespace RabbitMQ.Client
     ///  Alternatively, an API tutorial can be found in the User Guide.
     /// </para>
     /// <para>
-    /// Extends the <see cref="IDisposable"/> interface, so that the "using"
+    /// Extends the <see cref="IDisposable"/> and the <see cref="IAsyncDisposable"/> interface, so that the "using"
     /// statement can be used to scope the lifetime of a connection when
     /// appropriate.
     /// </para>
     /// </remarks>
-    public interface IConnection : INetworkConnection, IDisposable
+    public interface IConnection : INetworkConnection, IAsyncDisposable, IDisposable
     {
         /// <summary>
         /// The maximum channel number this connection supports (0 if unlimited).

projects/RabbitMQ.Client/Impl/AutorecoveringConnection.cs

@@ -264,7 +264,9 @@ await RecordChannelAsync(channel, channelsSemaphoreHeld: false, cancellationToke
             return channel;
         }
 
-        public void Dispose()
+        public void Dispose() => DisposeAsync().AsTask().GetAwaiter().GetResult();
+        
+        public async ValueTask DisposeAsync()
         {
             if (_disposed)
             {
@@ -273,7 +275,8 @@ public void Dispose()
 
             try
             {
-                _innerConnection.Dispose();
+                await _innerConnection.DisposeAsync()
+                    .ConfigureAwait(false);
             }
             catch (OperationInterruptedException)
             {

projects/RabbitMQ.Client/Impl/Connection.cs

@@ -485,7 +485,9 @@ internal ValueTask WriteAsync(RentedMemory frames, CancellationToken cancellatio
             return _frameHandler.WriteAsync(frames, cancellationToken);
         }
 
-        public void Dispose()
+        public void Dispose() => DisposeAsync().AsTask().GetAwaiter().GetResult();
+        
+        public async ValueTask DisposeAsync()
         {
             if (_disposed)
             {
@@ -496,7 +498,8 @@ public void Dispose()
             {
                 if (IsOpen)
                 {
-                    this.AbortAsync().GetAwaiter().GetResult();
+                    await this.AbortAsync()
+                        .ConfigureAwait(false);
                 }
 
                 _session0.Dispose();