Undo some changes, look for CI env var to determine if in continuous integration environment (https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables), and add FUTURE

Author: lukebakken

projects/RabbitMQ.Client/client/impl/Connection.cs

@@ -82,6 +82,11 @@ public Connection(ConnectionConfig config, IFrameHandler frameHandler)
             _mainLoopTask = Task.Run(MainLoop);
             try
             {
+                /*
+                 * TODO FUTURE
+                 * Connection should not happen in ctor, instead change
+                 * the API so that it's awaitable
+                 */
                 OpenAsync().AsTask().GetAwaiter().GetResult();
             }
             catch

projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs

@@ -306,7 +306,8 @@ private async Task WriteLoop()
                         ArrayPool<byte>.Shared.Return(segment.Array);
                     }
 
-                    await _pipeWriter.FlushAsync().ConfigureAwait(false);
+                    await _pipeWriter.FlushAsync()
+                        .ConfigureAwait(false);
                 }
             }
             catch (Exception ex)

projects/Unit/Fixtures.cs

@@ -71,7 +71,7 @@ public IntegrationFixture(ITestOutputHelper output)
             }
             else
             {
-                _waitSpan = TimeSpan.FromSeconds(20);
+                _waitSpan = TimeSpan.FromSeconds(10);
             }
         }
 
@@ -452,12 +452,21 @@ public static string CertificatesDirectory()
 
         private static bool IsRunningInCI()
         {
+            if (bool.TryParse(Environment.GetEnvironmentVariable("CI"), out bool ci))
+            {
+                if (ci == true)
+                {
+                    return true;
+                }
+            }
+
             string concourse = Environment.GetEnvironmentVariable("CONCOURSE_CI_BUILD");
             string gha = Environment.GetEnvironmentVariable("GITHUB_ACTIONS");
             if (String.IsNullOrWhiteSpace(concourse) && String.IsNullOrWhiteSpace(gha))
             {
                 return false;
             }
+
             return true;
         }
     }