All methods that return Tasks should have the Async suffix #1296

Author: lukebakken

projects/RabbitMQ.Client/client/impl/Connection.Commands.cs

@@ -37,7 +37,6 @@
 using RabbitMQ.Client.Exceptions;
 using RabbitMQ.Client.Impl;
 using RabbitMQ.Client.Logging;
-using RabbitMQ.Util;
 
 namespace RabbitMQ.Client.Framing.Impl
 {
@@ -74,17 +73,17 @@ internal void HandleConnectionUnblocked()
         private async ValueTask OpenAsync()
         {
             RabbitMqClientEventSource.Log.ConnectionOpened();
-            await StartAndTune().ConfigureAwait(false);
+            await StartAndTuneAsync().ConfigureAwait(false);
             await _channel0.ConnectionOpenAsync(_config.VirtualHost);
         }
 
-        private async ValueTask StartAndTune()
+        private async ValueTask StartAndTuneAsync()
         {
             var connectionStartCell = new TaskCompletionSource<ConnectionStartDetails>(TaskCreationOptions.RunContinuationsAsynchronously);
             _channel0.m_connectionStartCell = connectionStartCell;
             _channel0.HandshakeContinuationTimeout = _config.HandshakeContinuationTimeout;
             _frameHandler.ReadTimeout = _config.HandshakeContinuationTimeout;
-            await _frameHandler.SendHeader().ConfigureAwait(false);
+            await _frameHandler.SendHeaderAsync().ConfigureAwait(false);
             ConnectionStartDetails connectionStart = await connectionStartCell.Task.ConfigureAwait(false);
 
             if (connectionStart is null)

projects/RabbitMQ.Client/client/impl/IFrameHandler.cs

@@ -65,7 +65,7 @@ internal interface IFrameHandler
         ///</summary>
         bool TryReadFrame(out InboundFrame frame);
 
-        ValueTask SendHeader();
+        ValueTask SendHeaderAsync();
 
         ValueTask WriteAsync(ReadOnlyMemory<byte> memory);
     }

projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs

@@ -272,7 +272,7 @@ public bool TryReadFrame(out InboundFrame frame)
             return InboundFrame.TryReadFrameFromPipe(_pipeReader, _amqpTcpEndpoint.MaxMessageSize, out frame);
         }
 
-        public async ValueTask SendHeader()
+        public async ValueTask SendHeaderAsync()
         {
             _pipeWriter.Write(ProtocolHeader);
             await _pipeWriter.FlushAsync().ConfigureAwait(false);