Allow setting TimeSpan.Zero as a heartbeat timeout value

lukebakken · lukebakken · commit 276c9a6f7f7f · 2025-01-24T07:21:42.000-08:00
diff --git a/projects/RabbitMQ.Client/Impl/SocketFrameHandler.cs b/projects/RabbitMQ.Client/Impl/SocketFrameHandler.cs
@@ -111,8 +111,11 @@ public TimeSpan ReadTimeout
             {
                 try
                 {
-                    _socket.ReceiveTimeout = value;
-                    _stream.ReadTimeout = (int)value.TotalMilliseconds;
+                    if (value != default)
+                    {
+                        _socket.ReceiveTimeout = value;
+                        _stream.ReadTimeout = (int)value.TotalMilliseconds;
+                    }
                 }
                 catch (SocketException)
                 {
@@ -125,8 +128,11 @@ public TimeSpan WriteTimeout
         {
             set
             {
-                _socket.Client.SendTimeout = (int)value.TotalMilliseconds;
-                _stream.WriteTimeout = (int)value.TotalMilliseconds;
+                if (value != default)
+                {
+                    _socket.Client.SendTimeout = (int)value.TotalMilliseconds;
+                    _stream.WriteTimeout = (int)value.TotalMilliseconds;
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,11 @@ public TimeSpan ReadTimeout`
`111`	`111`	`{`
`112`	`112`	`try`
`113`	`113`	`{`
`114`		`- _socket.ReceiveTimeout = value;`
`115`		`- _stream.ReadTimeout = (int)value.TotalMilliseconds;`
	`114`	`+ if (value != default)`
	`115`	`+ {`
	`116`	`+ _socket.ReceiveTimeout = value;`
	`117`	`+ _stream.ReadTimeout = (int)value.TotalMilliseconds;`
	`118`	`+ }`
`116`	`119`	`}`
`117`	`120`	`catch (SocketException)`
`118`	`121`	`{`
`@@ -125,8 +128,11 @@ public TimeSpan WriteTimeout`
`125`	`128`	`{`
`126`	`129`	`set`
`127`	`130`	`{`
`128`		`- _socket.Client.SendTimeout = (int)value.TotalMilliseconds;`
`129`		`- _stream.WriteTimeout = (int)value.TotalMilliseconds;`
	`131`	`+ if (value != default)`
	`132`	`+ {`
	`133`	`+ _socket.Client.SendTimeout = (int)value.TotalMilliseconds;`
	`134`	`+ _stream.WriteTimeout = (int)value.TotalMilliseconds;`
	`135`	`+ }`
`130`	`136`	`}`
`131`	`137`	`}`
`132`	`138`