* Acquire / release outstanding confirms semaphore *before* confirms semaphore.

Author: lukebakken

projects/RabbitMQ.Client/Impl/Channel.PublisherConfirms.cs

@@ -282,16 +282,12 @@ await _confirmSemaphore.WaitAsync(reason.CancellationToken)
         {
             if (_publisherConfirmationsEnabled)
             {
-                /*
-                if (_publisherConfirmationTrackingEnabled)
+                if (_publisherConfirmationTrackingEnabled &&
+                    _maxOutstandingConfirmationsSemaphore is not null)
                 {
-                    if (_maxOutstandingConfirmationsSemaphore is not null)
-                    {
-                        await _maxOutstandingConfirmationsSemaphore.WaitAsync(cancellationToken)
-                            .ConfigureAwait(false);
-                    }
+                    await _maxOutstandingConfirmationsSemaphore.WaitAsync(cancellationToken)
+                        .ConfigureAwait(false);
                 }
-                */
 
                 await _confirmSemaphore.WaitAsync(cancellationToken)
                     .ConfigureAwait(false);
@@ -343,19 +339,19 @@ private async Task MaybeEndPublisherConfirmationTracking(PublisherConfirmationIn
         {
             if (_publisherConfirmationsEnabled)
             {
+                if (_publisherConfirmationTrackingEnabled &&
+                    _maxOutstandingConfirmationsSemaphore is not null)
+                {
+                    _maxOutstandingConfirmationsSemaphore.Release();
+                }
+
                 _confirmSemaphore.Release();
 
                 if (publisherConfirmationInfo is not null)
                 {
                     await publisherConfirmationInfo.MaybeWaitForConfirmationAsync(cancellationToken)
                         .ConfigureAwait(false);
                 }
-
-                if (_publisherConfirmationTrackingEnabled &&
-                    _maxOutstandingConfirmationsSemaphore is not null)
-                {
-                    // _maxOutstandingConfirmationsSemaphore.Release();
-                }
             }
         }
     }