Skip to content

Commit 71dee0e

Browse files
committed
mark segfaulting test
1 parent a32ba79 commit 71dee0e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

R/read.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,8 @@ process_cpl_read_ogr_stream = function(x, default_crs, num_features, fid_column_
233233
df = suppressWarnings(nanoarrow::convert_array_stream(x, size = num_features))
234234

235235
df[is_geometry_column] = lapply(df[is_geometry_column], function(x) {
236-
x = sf::st_as_sfc(wk::as_wkb(x))
237-
st_set_crs(x, crs)
236+
attributes(x) <- NULL
237+
sf::st_as_sfc(wk::new_wk_wkb(x, crs = crs))
238238
})
239239

240240
# Prefer "geometry" as the geometry column name

tests/testthat/test_sp.R

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ test_that("Can convert `XY` objects to sp", {
104104
})
105105

106106
test_that("Can't convert `M` dimension to sp", {
107+
# Segfaults using the stream interface
108+
skip_if(default_st_read_use_stream())
107109
skip_if_not_installed("sp")
108110
skip_if_not(sf_extSoftVersion()[["GDAL"]] >= "2.1.0")
109111
x <- read_sf(system.file("shape/storms_xyzm_feature.shp", package = "sf"), quiet = TRUE)

0 commit comments

Comments
 (0)