feat: read_xml.textConnection() (#461)

trevorld · web-flow · commit e994e0e1c86c · 2025-07-21T22:41:25.000+02:00
* Adds an S3 method for `read_xml()` for `textConnection()` objects. closes #460
diff --git a/NAMESPACE b/NAMESPACE
@@ -50,6 +50,7 @@ S3method(read_xml,character)
 S3method(read_xml,connection)
 S3method(read_xml,raw)
 S3method(read_xml,response)
+S3method(read_xml,textConnection)
 S3method(tree_structure,xml_missing)
 S3method(tree_structure,xml_node)
 S3method(tree_structure,xml_nodeset)
diff --git a/R/xml_parse.R b/R/xml_parse.R
@@ -182,6 +182,14 @@ read_xml.response <- function(x,
   )
 }
 
+#' @export
+read_xml.textConnection <- function(x,
+                                    encoding = "",
+                                    ...) {
+  s <- paste(readLines(x), collapse = "\n")
+  read_xml.character(s, ...)
+}
+
 #' Download a HTML or XML file
 #'
 #' Libcurl implementation of `C_download` (the "internal" download method)
diff --git a/tests/testthat/test-xml_parse.R b/tests/testthat/test-xml_parse.R
@@ -117,3 +117,11 @@ test_that("read_xml and read_html fail with > 1 input", {
 #  res <- read_html('<html><head')
 #  expect_s3_class(res, "xml_document")
 #})
+
+test_that("read_xml from a textConnection", {
+  s <- '<?xml version="1.0" encoding="UTF-8"?>\n<outer>\n<inner>Inner</inner>\n</outer>'
+  con <- textConnection(s)
+  x <- read_xml(con)
+  close(con)
+  expect_s3_class(x, "xml_document")
+})

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,14 @@ read_xml.response <- function(x,`
`182`	`182`	`)`
`183`	`183`	`}`
`184`	`184`
	`185`	`+#' @export`
	`186`	`+read_xml.textConnection <- function(x,`
	`187`	`+ encoding = "",`
	`188`	`+ ...) {`
	`189`	`+ s <- paste(readLines(x), collapse = "\n")`
	`190`	`+ read_xml.character(s, ...)`
	`191`	`+}`
	`192`	`+`
`185`	`193`	`#' Download a HTML or XML file`
`186`	`194`	`#'`
`187`	`195`	#' Libcurl implementation of `C_download` (the "internal" download method)