Skip to content

Commit bda9fa7

Browse files
committed
Remove a new non-api call
1 parent ece90bb commit bda9fa7

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

NEWS.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# xml2 1.3.8
2+
3+
* Replace new "non-api" call IS_S4_OBJECT with Rf_isS4
4+
5+
* Windows: update fallback libs (for R < 4.3) to libxml2 2.11.5
6+
17
# xml2 1.3.7
28

39
* Windows: use libxml2 from Rtools if found

src/xml2_utils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ inline int inherits3(SEXP x, const char *name) {
2626
inline const NodeType getNodeType(SEXP x) {
2727

2828
// for fhircrackr
29-
if (IS_S4_OBJECT(x)) {
29+
if (Rf_isS4(x)) {
3030
if (inherits3(x, "xml_node")) {
3131
return(NodeType::node);
3232
} else if (inherits3(x, "xml_nodeset")) {

0 commit comments

Comments
 (0)