is_dictionaryish(NULL) now returns true (#1741)

Author: ilovemane

NEWS.md

@@ -6,6 +6,8 @@
 * `env_unlock()` is now defunct because recent versions of R no long
   make it possible to unlock an environment (#1705). Make sure to use an
   up-to-date version of pkgload (>= 1.4.0) following this change.
+  
+* `is_dictionaryish()` now will return TRUE for NULL (@ilovemane, #1712).
 
 
 # rlang 1.1.4

R/attr.R

@@ -20,7 +20,7 @@
 #'   a logical vector as long as the input.
 #'
 #' @details
-#' `is_named()` always returns `TRUE` for empty vectors because 
+#' `is_named()` always returns `TRUE` for empty vectors because
 #'
 #' @examples
 #' # is_named() is a scalar predicate about the whole vector of names:
@@ -110,6 +110,10 @@ detect_void_name <- function(x) {
 is_dictionaryish <- function(x) {
   # 2022-01: Used in many packages. Don't deprecate without a
   # replacement.
+  if (is.null(x)) {
+    return(TRUE)
+  }
+
   if (!length(x)) {
     return(!is.null(x))
   }
@@ -118,6 +122,7 @@ is_dictionaryish <- function(x) {
 }
 
 
+
 #' Does an object have an element with this name?
 #'
 #' This function returns a logical value that indicates if a data

tests/testthat/test-attr.R

@@ -186,3 +186,8 @@ test_that("zap_srcref() works on calls", {
   expect_null(attributes(zap_srcref(call)))
   expect_true("srcref" %in% names(attributes(call)))
 })
+
+test_that("is_dictionaryish return true if is NULL", {
+
+  expect_true(is_dictionaryish(NULL))
+})