fix(qwik-nx): bump vitest to fix the issue with undefined styles in tests (#130)

Author: dmitry-stepanenko

e2e/qwik-nx-e2e/tests/application-basic-behavior.suite.ts

@@ -36,6 +36,9 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
       await runNxCommandAsync(
         `generate qwik-nx:${generator} ${projectNameParam} --no-interactive`
       );
+      await runNxCommandAsync(
+        `generate qwik-nx:component my-test-component --project=${project} --unitTestRunner=vitest --no-interactive`
+      );
     }, DEFAULT_E2E_TIMEOUT);
 
     afterAll(async () => {
@@ -74,6 +77,20 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
       DEFAULT_E2E_TIMEOUT
     );
 
+    it(
+      'unit tests should pass in the created app',
+      async () => {
+        const result = await runNxCommandAsync(`test ${project}`);
+        expect(result.stdout).toContain(
+          `Successfully ran target test for project ${project}`
+        );
+        expect(stripConsoleColors(result.stdout)).toContain(
+          `Test Files  1 passed`
+        );
+      },
+      DEFAULT_E2E_TIMEOUT
+    );
+
     it(
       'should run build with a specified configuration',
       async () => {
@@ -147,7 +164,7 @@ export function testApplicationBasicBehavior(generator: 'app' | 'preset') {
 
 async function checkPageResponses(host: string) {
   // wait for a while to make sure everything is settled
-  await new Promise(r => setTimeout(r, 3000));
+  await new Promise((r) => setTimeout(r, 3000));
   const domParser = new DOMParser();
   const pages = ['', 'flower'];
   for (const page of pages) {

packages/qwik-nx/migrations.json

@@ -144,6 +144,14 @@
           "version": "~2.8.7"
         }
       }
+    },
+    "0.15.4": {
+      "version": "0.15.4",
+      "packages": {
+        "vitest": {
+          "version": "^0.28.5"
+        }
+      }
     }
   }
 }

packages/qwik-nx/src/utils/add-common-qwik-dependencies.ts

@@ -9,6 +9,7 @@ import {
   qwikEslintPluginVersion,
   qwikVersion,
   undiciVersion,
+  vitestVersion,
   viteTsconfigPathsVersion,
   viteVersion,
 } from './versions';
@@ -22,17 +23,10 @@ export function addCommonQwikDependencies(host: Tree): GeneratorCallback {
       '@builder.io/qwik-city': qwikCityVersion,
       'eslint-plugin-qwik': qwikEslintPluginVersion,
       vite: viteVersion,
+      vitest: vitestVersion, // TODO: vitest is also installed by "@nrwl/vite", but our version is higher
       'vite-tsconfig-paths': viteTsconfigPathsVersion,
       'node-fetch': nodeFetchVersion,
       undici: undiciVersion,
-      // TODO: dependencies below should be setup correctly by Nx's generator, so not needed to provide them here?
-      // "@types/eslint": typesEslint,
-      // '@types/node': 'latest',
-      // "@typescript-eslint/eslint-plugin": tsEslintVersion,
-      // "@typescript-eslint/parser": tsEslintVersion,
-      // "eslint": eslintVersion,
-      // "prettier": prettierVersion,
-      // "typescript": typescriptVersion,
     }
   );
 }