[Snippets] add chunkArray function to array manipulation snippets #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuziferSenpai
requested review from
Mathys-Gasnier,
psychlone77 and
saminjay
as code owners
LuziferSenpai
changed the title
saminjay
reviewed
Jan 8, 2025
| if (!Array.isArray(array)) { | ||
| throw new TypeError('Expected an array as the first argument.'); | ||
| } | ||
| if (typeof chunkSize !== 'number' || chunkSize <= 0) { |
Collaborator
There was a problem hiding this comment.
You need to specifically check for NaN, its type is number
Author
There was a problem hiding this comment.
Okay I updated it to also check for NaN.
Mathys-Gasnier
approved these changes
Jan 9, 2025
majvax
requested changes
Jan 9, 2025
Collaborator
majvax
left a comment
majvax
left a comment
There was a problem hiding this comment.
Please fix the conflicts by merging remote main into your main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots