core/window: fix UAF in createQQuickWindow

outfoxxed · outfoxxed · commit fef840d2e8ed · 2025-05-17T04:01:45.000-07:00
diff --git a/src/window/proxywindow.cpp b/src/window/proxywindow.cpp
@@ -134,6 +134,7 @@ void ProxyWindowBase::ensureQWindow() {
 
 	if (useOldWindow) return;
 	delete this->window;
+	this->window = nullptr; // createQQuickWindow may indirectly reference this->window
 	this->window = this->createQQuickWindow();
 	this->window->setFormat(format);
 }

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,7 @@ void ProxyWindowBase::ensureQWindow() {`
`134`	`134`
`135`	`135`	`if (useOldWindow) return;`
`136`	`136`	`delete this->window;`
	`137`	`+ this->window = nullptr; // createQQuickWindow may indirectly reference this->window`
`137`	`138`	`this->window = this->createQQuickWindow();`
`138`	`139`	`this->window->setFormat(format);`
`139`	`140`	`}`