lint errors

Author: CMurtagh-LGTM

src/core/fzy.cpp

@@ -1,9 +1,14 @@
 #include "fzy.h"
 #include <algorithm>
 #include <array>
-#include <bitset>
-
-#include <QVariant>
+#include <cmath>
+#include <limits>
+
+#include <qnamespace.h>
+#include <qstring.h>
+#include <qstringview.h>
+#include <qtypes.h>
+#include <qvariant.h>
 #include <span>
 
 namespace {
@@ -90,7 +95,7 @@ void precomputeBonus(QStringView haystack, std::span<double> matchBonus) {
 	/* Which positions are beginning of words */
 	QChar lastCh = '/';
 	for (qsizetype index = 0; index < haystack.size(); index++) {
-		QChar ch = haystack[index];
+		const QChar ch = haystack[index];
 		matchBonus[index] = getBonus(lastCh, ch);
 		lastCh = ch;
 	}
@@ -119,15 +124,15 @@ void matchRow(
     std::span<const double> lastD,
     std::span<const double> lastM
 ) {
-	qsizetype needleLen = match.lowerNeedle.size();
-	qsizetype haystackLen = match.lowerHaystack.size();
+	const qsizetype needleLen = match.lowerNeedle.size();
+	const qsizetype haystackLen = match.lowerHaystack.size();
 
-	QStringView lowerNeedle = match.lowerNeedle;
-	QStringView lowerHaystack = match.lowerHaystack;
-	std::span<const double> matchBonus = match.matchBonus;
+	const QStringView lowerNeedle = match.lowerNeedle;
+	const QStringView lowerHaystack = match.lowerHaystack;
+	const std::span<const double> matchBonus = match.matchBonus;
 
 	double prevScore = SCORE_MIN;
-	double gapScore = row == needleLen - 1 ? SCORE_GAP_TRAILING : SCORE_GAP_INNER;
+	const double gapScore = row == needleLen - 1 ? SCORE_GAP_TRAILING : SCORE_GAP_INNER;
 
 	/* These will not be used with this value, but not all compilers see it */
 	double prevM = SCORE_MIN;
@@ -168,7 +173,7 @@ double match(QStringView needle, QStringView haystack) {
 		return SCORE_MAX;
 	}
 
-	MatchStruct match = setupMatchStruct(needle, haystack);
+	const MatchStruct match = setupMatchStruct(needle, haystack);
 
 	/*
 	 * D Stores the best score for this position ending with a match.
@@ -198,7 +203,7 @@ FzyFinder::filter(const QString& needle, const QList<QObject*>& haystacks, const
 		}
 	}
 	std::ranges::stable_sort(list, std::ranges::greater(), &ScoredResult::score);
-	auto out = QList<QObject*>(static_cast<qsizetype>(list.size()));
+	auto out = QList<QObject*>(list.size());
 	std::ranges::transform(list, out.begin(), [](const ScoredResult& result) -> QObject* {
 		return result.obj;
 	});