core: don't show " at " in qml warnings if object name is empty

outfoxxed · outfoxxed · commit b898592db7a2 · 2025-05-26T17:44:45.000-07:00
diff --git a/src/core/generation.cpp b/src/core/generation.cpp
@@ -327,13 +327,13 @@ void EngineGeneration::onEngineWarnings(const QList<QQmlError>& warnings) const
 
 		QString objectName;
 		auto desc = error.description();
-		if (auto i = desc.indexOf(": "); i != -1) {
-			objectName = desc.first(i);
+		if (auto i = desc.indexOf(": "); i != -1 && desc.startsWith("QML ")) {
+			objectName = desc.first(i) + " at ";
 			desc = desc.sliced(i + 2);
 		}
 
-		qCWarning(logScene).noquote().nospace() << objectName << " at " << rel << '[' << error.line()
-		                                        << ':' << error.column() << "]: " << desc;
+		qCWarning(logScene).noquote().nospace()
+		    << objectName << rel << '[' << error.line() << ':' << error.column() << "]: " << desc;
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -327,13 +327,13 @@ void EngineGeneration::onEngineWarnings(const QList<QQmlError>& warnings) const`
`327`	`327`
`328`	`328`	`QString objectName;`
`329`	`329`	`auto desc = error.description();`
`330`		`- if (auto i = desc.indexOf(": "); i != -1) {`
`331`		`- objectName = desc.first(i);`
	`330`	`+ if (auto i = desc.indexOf(": "); i != -1 && desc.startsWith("QML ")) {`
	`331`	`+ objectName = desc.first(i) + " at ";`
`332`	`332`	`desc = desc.sliced(i + 2);`
`333`	`333`	`}`
`334`	`334`
`335`		`- qCWarning(logScene).noquote().nospace() << objectName << " at " << rel << '[' << error.line()`
`336`		`- << ':' << error.column() << "]: " << desc;`
	`335`	`+ qCWarning(logScene).noquote().nospace()`
	`336`	`+ << objectName << rel << '[' << error.line() << ':' << error.column() << "]: " << desc;`
`337`	`337`	`}`
`338`	`338`	`}`
`339`	`339`