core/popupwindow: wait for polish to reposition

Author: outfoxxed

src/window/popupwindow.cpp

@@ -126,7 +126,20 @@ qint32 ProxyPopupWindow::relativeY() const {
 PopupAnchor* ProxyPopupWindow::anchor() { return &this->mAnchor; }
 
 void ProxyPopupWindow::reposition() {
-	if (this->window != nullptr) {
-		PopupPositioner::instance()->reposition(&this->mAnchor, this->window);
+	// not gated on pendingReposition as a polish might not be triggered in edge cases
+	if (this->window) {
+		this->pendingReposition = true;
+		this->schedulePolish();
+	}
+}
+
+void ProxyPopupWindow::onPolished() {
+	this->ProxyWindowBase::onPolished();
+	if (this->pendingReposition) {
+		this->pendingReposition = false;
+
+		if (this->window) {
+			PopupPositioner::instance()->reposition(&this->mAnchor, this->window);
+		}
 	}
 }

src/window/popupwindow.hpp

@@ -87,6 +87,7 @@ class ProxyPopupWindow: public ProxyWindowBase {
 
 	void completeWindow() override;
 	void postCompleteWindow() override;
+	void onPolished() override;
 
 	void setScreen(QuickshellScreenInfo* screen) override;
 	void setVisible(bool visible) override;
@@ -119,4 +120,5 @@ private slots:
 
 	PopupAnchor mAnchor {this};
 	bool wantsVisible = false;
+	bool pendingReposition = false;
 };