Skip to content

Commit 8450543

Browse files
committed
service/mpris!: convert trackArtists from list<string> to string
Most people treat it as a string already, which breaks in Qt 6.8, and I have not seen a meaningful multi-artist response.
1 parent dbaaf55 commit 8450543

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/services/mpris/player.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ void MprisPlayer::onMetadataChanged() {
301301
auto trackTitleChanged = this->setTrackTitle(trackTitle.isNull() ? "Unknown Track" : trackTitle);
302302

303303
auto trackArtists = this->pMetadata.get().value("xesam:artist").value<QVector<QString>>();
304-
auto trackArtistsChanged = this->setTrackArtists(trackArtists);
304+
auto trackArtistsChanged = this->setTrackArtists(trackArtists.join(", "));
305305

306306
auto trackAlbum = this->pMetadata.get().value("xesam:album").toString();
307307
auto trackAlbumChanged = this->setTrackAlbum(trackAlbum.isNull() ? "Unknown Album" : trackAlbum);

src/services/mpris/player.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ class MprisPlayer: public QObject {
141141
/// The current track's album artist, or "Unknown Artist" if none was provided.
142142
Q_PROPERTY(QString trackAlbumArtist READ trackAlbumArtist NOTIFY trackAlbumArtistChanged);
143143
/// The current track's artists, or an empty list if none were provided.
144-
Q_PROPERTY(QVector<QString> trackArtists READ trackArtists NOTIFY trackArtistsChanged);
144+
Q_PROPERTY(QString trackArtists READ trackArtists NOTIFY trackArtistsChanged);
145145
/// The current track's art url, or `""` if none was provided.
146146
Q_PROPERTY(QString trackArtUrl READ trackArtUrl NOTIFY trackArtUrlChanged);
147147
/// The playback state of the media player.
@@ -373,7 +373,7 @@ private slots:
373373
QString mTrackId;
374374
QString mTrackUrl;
375375
QString mTrackTitle;
376-
QVector<QString> mTrackArtists;
376+
QString mTrackArtists;
377377
QString mTrackAlbum;
378378
QString mTrackAlbumArtist;
379379
QString mTrackArtUrl;

0 commit comments

Comments
 (0)