Skip to content

Commit 823456b

Browse files
committed
service/tray: silence compliance warnings
Almost every tray item is missing properties and these messages pollute the log, masking more useful warnings.
1 parent eb391e3 commit 823456b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/services/status_notifier/item.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,19 +65,19 @@ StatusNotifierItem::StatusNotifierItem(const QString& address, QObject* parent)
6565
QObject::connect(this->item, &DBusStatusNotifierItem::NewIcon, this, [this]() {
6666
this->pIconName.requestUpdate();
6767
this->pIconPixmaps.requestUpdate();
68-
this->pIconThemePath.requestUpdate();
68+
if (this->pIconThemePath.exists()) this->pIconThemePath.requestUpdate();
6969
});
7070

7171
QObject::connect(this->item, &DBusStatusNotifierItem::NewOverlayIcon, this, [this]() {
7272
this->pOverlayIconName.requestUpdate();
7373
this->pOverlayIconPixmaps.requestUpdate();
74-
this->pIconThemePath.requestUpdate();
74+
if (this->pIconThemePath.exists()) this->pIconThemePath.requestUpdate();
7575
});
7676

7777
QObject::connect(this->item, &DBusStatusNotifierItem::NewAttentionIcon, this, [this]() {
7878
this->pAttentionIconName.requestUpdate();
7979
this->pAttentionIconPixmaps.requestUpdate();
80-
this->pIconThemePath.requestUpdate();
80+
if (this->pIconThemePath.exists()) this->pIconThemePath.requestUpdate();
8181
});
8282

8383
QObject::connect(this->item, &DBusStatusNotifierItem::NewToolTip, this, [this]() {

src/services/status_notifier/item.hpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -213,18 +213,18 @@ private slots:
213213
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pId, bId, properties, "Id");
214214
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pTitle, bTitle, properties, "Title");
215215
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pStatus, bStatus, properties, "Status");
216-
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pCategory, bCategory, properties, "Category");
216+
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pCategory, bCategory, properties, "Category", false);
217217
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIconThemePath, bIconThemePath, properties, "IconThemePath", false);
218218
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIconName, bIconName, properties, "IconName", false);
219219
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIconPixmaps, bIconPixmaps, properties, "IconPixmap", false);
220-
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconName, bOverlayIconName, properties, "OverlayIconName");
221-
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconPixmaps, bOverlayIconPixmaps, properties, "OverlayIconPixmap");
222-
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconName, bAttentionIconName, properties, "AttentionIconName");
223-
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconPixmaps, bAttentionIconPixmaps, properties, "AttentionIconPixmap");
220+
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconName, bOverlayIconName, properties, "OverlayIconName", false);
221+
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pOverlayIconPixmaps, bOverlayIconPixmaps, properties, "OverlayIconPixmap", false);
222+
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconName, bAttentionIconName, properties, "AttentionIconName", false);
223+
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionIconPixmaps, bAttentionIconPixmaps, properties, "AttentionIconPixmap", false);
224224
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pAttentionMovieName, bAttentionMovieName, properties, "AttentionMovieName", false);
225225
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pTooltip, bTooltip, properties, "ToolTip");
226-
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIsMenu, bIsMenu, properties, "ItemIsMenu");
227-
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pMenuPath, bMenuPath, properties, "Menu");
226+
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pIsMenu, bIsMenu, properties, "ItemIsMenu", false);
227+
QS_DBUS_PROPERTY_BINDING(StatusNotifierItem, pMenuPath, bMenuPath, properties, "Menu", false);
228228
// clang-format on
229229
};
230230

0 commit comments

Comments
 (0)