Skip to content

Commit 324fe92

Browse files
committed
all: remove unused dbus props and warnings for non-required ones
1 parent b43b4a0 commit 324fe92

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/dbus/dbusmenu/dbusmenu.hpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,6 @@ class DBusMenu: public QObject {
122122
QSDOC_HIDE void iconThemePathChanged();
123123

124124
public:
125-
Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, quint32, version);
126-
Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, QString, textDirection);
127-
Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, QString, status);
128125
Q_OBJECT_BINDABLE_PROPERTY(DBusMenu, QStringList, iconThemePath, &DBusMenu::iconThemePathChanged);
129126

130127
void prepareToShow(qint32 item, qint32 depth);
@@ -147,10 +144,14 @@ private slots:
147144
private:
148145
void updateLayoutRecursive(const DBusMenuLayout& layout, DBusMenuItem* parent, qint32 depth);
149146

150-
QS_DBUS_PROPERTY_BINDING(DBusMenu, pVersion, version, properties, "Version");
151-
QS_DBUS_PROPERTY_BINDING(DBusMenu, pTextDirection, textDirection, properties, "TextDirection");
152-
QS_DBUS_PROPERTY_BINDING(DBusMenu, pStatus, status, properties, "Status");
153-
QS_DBUS_PROPERTY_BINDING(DBusMenu, pIconThemePath, iconThemePath, properties, "IconThemePath");
147+
QS_DBUS_PROPERTY_BINDING(
148+
DBusMenu,
149+
pIconThemePath,
150+
iconThemePath,
151+
properties,
152+
"IconThemePath",
153+
false
154+
);
154155

155156
DBusMenuInterface* interface = nullptr;
156157
};

src/services/mpris/player.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -408,8 +408,8 @@ private slots:
408408
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pDesktopEntry, bDesktopEntry, appProperties, "DesktopEntry");
409409
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanQuit, bCanQuit, appProperties, "CanQuit");
410410
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanRaise, bCanRaise, appProperties, "CanRaise");
411-
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pFullscreen, bFullscreen, appProperties, "Fullscreen");
412-
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanSetFullscreen, bCanSetFullscreen, appProperties, "CanSetFullscreen");
411+
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pFullscreen, bFullscreen, appProperties, "Fullscreen", false);
412+
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pCanSetFullscreen, bCanSetFullscreen, appProperties, "CanSetFullscreen", false);
413413
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pSupportedUriSchemes, bSupportedUriSchemes, appProperties, "SupportedUriSchemes");
414414
QS_DBUS_PROPERTY_BINDING(MprisPlayer, pSupportedMimeTypes, bSupportedMimeTypes, appProperties, "SupportedMimeTypes");
415415

0 commit comments

Comments
 (0)