Skip to content

Commit 2996e40

Browse files
committed
core/plugin: rename QuickshellPlugin to QsEnginePlugin
Fixes conflict with the autogenerated qml plugin of the same name.
1 parent afa1b6f commit 2996e40

File tree

8 files changed

+27
-27
lines changed

8 files changed

+27
-27
lines changed

src/core/generation.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ EngineGeneration::EngineGeneration(const QDir& rootPath, QmlScanner scanner)
4242
this->engine->addImageProvider("qsimage", new QsImageProvider());
4343
this->engine->addImageProvider("qspixmap", new QsPixmapProvider());
4444

45-
QuickshellPlugin::runConstructGeneration(*this);
45+
QsEnginePlugin::runConstructGeneration(*this);
4646
}
4747

4848
EngineGeneration::~EngineGeneration() {
@@ -141,7 +141,7 @@ void EngineGeneration::postReload() {
141141
// This can be called on a generation during its destruction.
142142
if (this->engine == nullptr || this->root == nullptr) return;
143143

144-
QuickshellPlugin::runOnReload();
144+
QsEnginePlugin::runOnReload();
145145
PostReloadHook::postReloadTree(this->root);
146146
this->singletonRegistry.onPostReload();
147147
}

src/core/plugin.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,41 +5,41 @@
55

66
#include "generation.hpp"
77

8-
static QVector<QuickshellPlugin*> plugins; // NOLINT
8+
static QVector<QsEnginePlugin*> plugins; // NOLINT
99

10-
void QuickshellPlugin::registerPlugin(QuickshellPlugin& plugin) { plugins.push_back(&plugin); }
10+
void QsEnginePlugin::registerPlugin(QsEnginePlugin& plugin) { plugins.push_back(&plugin); }
1111

12-
void QuickshellPlugin::initPlugins() {
12+
void QsEnginePlugin::initPlugins() {
1313
plugins.erase(
1414
std::remove_if(
1515
plugins.begin(),
1616
plugins.end(),
17-
[](QuickshellPlugin* plugin) { return !plugin->applies(); }
17+
[](QsEnginePlugin* plugin) { return !plugin->applies(); }
1818
),
1919
plugins.end()
2020
);
2121

22-
std::sort(plugins.begin(), plugins.end(), [](QuickshellPlugin* a, QuickshellPlugin* b) {
22+
std::sort(plugins.begin(), plugins.end(), [](QsEnginePlugin* a, QsEnginePlugin* b) {
2323
return b->dependencies().contains(a->name());
2424
});
2525

26-
for (QuickshellPlugin* plugin: plugins) {
26+
for (QsEnginePlugin* plugin: plugins) {
2727
plugin->init();
2828
}
2929

30-
for (QuickshellPlugin* plugin: plugins) {
30+
for (QsEnginePlugin* plugin: plugins) {
3131
plugin->registerTypes();
3232
}
3333
}
3434

35-
void QuickshellPlugin::runConstructGeneration(EngineGeneration& generation) {
36-
for (QuickshellPlugin* plugin: plugins) {
35+
void QsEnginePlugin::runConstructGeneration(EngineGeneration& generation) {
36+
for (QsEnginePlugin* plugin: plugins) {
3737
plugin->constructGeneration(generation);
3838
}
3939
}
4040

41-
void QuickshellPlugin::runOnReload() {
42-
for (QuickshellPlugin* plugin: plugins) {
41+
void QsEnginePlugin::runOnReload() {
42+
for (QsEnginePlugin* plugin: plugins) {
4343
plugin->onReload();
4444
}
4545
}

src/core/plugin.hpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66

77
class EngineGeneration;
88

9-
class QuickshellPlugin {
9+
class QsEnginePlugin {
1010
public:
11-
QuickshellPlugin() = default;
12-
virtual ~QuickshellPlugin() = default;
13-
QuickshellPlugin(QuickshellPlugin&&) = delete;
14-
QuickshellPlugin(const QuickshellPlugin&) = delete;
15-
void operator=(QuickshellPlugin&&) = delete;
16-
void operator=(const QuickshellPlugin&) = delete;
11+
QsEnginePlugin() = default;
12+
virtual ~QsEnginePlugin() = default;
13+
QsEnginePlugin(QsEnginePlugin&&) = delete;
14+
QsEnginePlugin(const QsEnginePlugin&) = delete;
15+
void operator=(QsEnginePlugin&&) = delete;
16+
void operator=(const QsEnginePlugin&) = delete;
1717

1818
virtual QString name() { return QString(); }
1919
virtual QList<QString> dependencies() { return {}; }
@@ -23,7 +23,7 @@ class QuickshellPlugin {
2323
virtual void constructGeneration(EngineGeneration& /*unused*/) {} // NOLINT
2424
virtual void onReload() {}
2525

26-
static void registerPlugin(QuickshellPlugin& plugin);
26+
static void registerPlugin(QsEnginePlugin& plugin);
2727
static void initPlugins();
2828
static void runConstructGeneration(EngineGeneration& generation);
2929
static void runOnReload();
@@ -33,6 +33,6 @@ class QuickshellPlugin {
3333
#define QS_REGISTER_PLUGIN(clazz) \
3434
[[gnu::constructor]] void qsInitPlugin() { \
3535
static clazz plugin; \
36-
QuickshellPlugin::registerPlugin(plugin); \
36+
QsEnginePlugin::registerPlugin(plugin); \
3737
}
3838
// NOLINTEND

src/io/init.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
namespace {
55

6-
class IoPlugin: public QuickshellPlugin {
6+
class IoPlugin: public QsEnginePlugin {
77
void onReload() override { DisownedProcessContext::destroyInstance(); }
88
};
99

src/launch/launch.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ int launch(const LaunchArgs& args, char** argv, QCoreApplication* coreApplicatio
212212
QQmlDebuggingEnabler::startTcpDebugServer(args.debugPort, wait);
213213
}
214214

215-
QuickshellPlugin::initPlugins();
215+
QsEnginePlugin::initPlugins();
216216

217217
// Base window transparency appears to be additive.
218218
// Use a fully transparent window with a colored rect.

src/wayland/init.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ void installPopupPositioner();
1515

1616
namespace {
1717

18-
class WaylandPlugin: public QuickshellPlugin {
18+
class WaylandPlugin: public QsEnginePlugin {
1919
QList<QString> dependencies() override { return {"window"}; }
2020

2121
bool applies() override {

src/window/init.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
namespace {
77

8-
class WindowPlugin: public QuickshellPlugin {
8+
class WindowPlugin: public QsEnginePlugin {
99
// _Window has to be registered before wayland or x11 modules, otherwise module overlays
1010
// will apply in the wrong order.
1111
QString name() override { return "window"; }

src/x11/init.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
namespace {
1111

12-
class X11Plugin: public QuickshellPlugin {
12+
class X11Plugin: public QsEnginePlugin {
1313
QList<QString> dependencies() override { return {"window"}; }
1414

1515
bool applies() override { return QGuiApplication::platformName() == "xcb"; }

0 commit comments

Comments
 (0)