removed no longer needed flag in connectors (#190)

* removed no longer supported boolean flag blockInThread
* made method SingleThreadedEventHandlingStrategy.block() private since its external usage is not supported anymore

Author: chrjohn

quickfixj-core/src/main/java/quickfix/SocketAcceptor.java

@@ -99,19 +99,15 @@ public SocketAcceptor(SessionFactory sessionFactory, SessionSettings settings) t
 
     @Override
     public void start() throws ConfigError, RuntimeError {
-        initialize(true);
+        initialize();
     }
 
-    private void initialize(boolean blockInThread) throws ConfigError {
+    private void initialize() throws ConfigError {
         if (isStarted.equals(Boolean.FALSE)) {
             eventHandlingStrategy.setExecutor(longLivedExecutor);
             startAcceptingConnections();
             isStarted = Boolean.TRUE;
-            if (blockInThread) {
-                eventHandlingStrategy.blockInThread();
-            } else {
-                eventHandlingStrategy.block();
-            }
+            eventHandlingStrategy.blockInThread();
         } else {
             log.warn("Ignored attempt to start already running SocketAcceptor.");
         }

quickfixj-core/src/main/java/quickfix/SocketInitiator.java

@@ -108,7 +108,7 @@ public SocketInitiator(SessionFactory sessionFactory, SessionSettings settings,
 
     @Override
     public void start() throws ConfigError, RuntimeError {
-        initialize(true);
+        initialize();
     }
 
     @Override
@@ -131,7 +131,7 @@ public void stop(boolean forceDisconnect) {
         }
     }
 
-    private void initialize(boolean blockInThread) throws ConfigError {
+    private void initialize() throws ConfigError {
         if (isStarted.equals(Boolean.FALSE)) {
             eventHandlingStrategy.setExecutor(longLivedExecutor);
             createSessionInitiators();
@@ -140,11 +140,7 @@ private void initialize(boolean blockInThread) throws ConfigError {
             }
             startInitiators();
             isStarted = Boolean.TRUE;
-            if (blockInThread) {
-                eventHandlingStrategy.blockInThread();
-            } else {
-                eventHandlingStrategy.block();
-            }
+            eventHandlingStrategy.blockInThread();
         } else {
             log.warn("Ignored attempt to start already running SocketInitiator.");
         }

quickfixj-core/src/main/java/quickfix/mina/SingleThreadedEventHandlingStrategy.java

@@ -81,7 +81,7 @@ public SessionConnector getSessionConnector() {
         return sessionConnector;
     }
 
-    public void block() {
+    private void block() {
         while (true) {
             synchronized (this) {
                 if (isStopped) {