Skip to content

Commit a31a648

Browse files
author
Guido Medina
committed
Most deprecated API calls fixed.
1 parent b4f6847 commit a31a648

16 files changed

+23
-25
lines changed

quickfixj-core/src/main/java/quickfix/mina/AbstractIoHandler.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void exceptionCaught(IoSession ioSession, Throwable cause) throws Excepti
7979
quickFixSession.disconnect(reason, true);
8080
} else {
8181
log.error(reason, cause);
82-
ioSession.close(true);
82+
ioSession.closeNow();
8383
}
8484
} else {
8585
log.error(reason, cause);
@@ -100,9 +100,9 @@ public void sessionClosed(IoSession ioSession) throws Exception {
100100
eventHandlingStrategy.onMessage(quickFixSession, EventHandlingStrategy.END_OF_STREAM );
101101
ioSession.removeAttribute(SessionConnector.QF_SESSION);
102102
}
103-
ioSession.close(true);
103+
ioSession.closeNow();
104104
} catch (Exception e) {
105-
ioSession.close(true);
105+
ioSession.closeNow();
106106
throw e;
107107
}
108108
}
@@ -120,14 +120,14 @@ public void messageReceived(IoSession ioSession, Object message) throws Exceptio
120120
} catch (InvalidMessage e) {
121121
if (MsgType.LOGON.equals(MessageUtils.getMessageType(messageString))) {
122122
log.error("Invalid LOGON message, disconnecting: " + e.getMessage());
123-
ioSession.close(true);
123+
ioSession.closeNow();
124124
} else {
125125
log.error("Invalid message: " + e.getMessage());
126126
}
127127
}
128128
} else {
129129
log.error("Disconnecting; received message for unknown session: " + messageString);
130-
ioSession.close(true);
130+
ioSession.closeNow();
131131
}
132132
}
133133

quickfixj-core/src/main/java/quickfix/mina/IoSessionResponder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public void disconnect() {
8484
// threading model and calling join will prevent the
8585
// close event from being processed by this thread (if
8686
// this thread is the MINA IO processor thread.
87-
ioSession.close(true);
87+
ioSession.closeNow();
8888
}
8989

9090
private void waitForScheduleMessagesToBeWritten() {

quickfixj-core/src/main/java/quickfix/mina/acceptor/AcceptorIoHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ protected void processMessage(IoSession protocolSession, Message message) throws
7272
// Session is already bound to another connection
7373
sessionLog
7474
.onErrorEvent("Multiple logons/connections for this session are not allowed");
75-
protocolSession.close(true);
75+
protocolSession.closeNow();
7676
return;
7777
}
7878
sessionLog.onEvent("Accepting session " + qfSession.getSessionID() + " from "
@@ -105,7 +105,7 @@ protected void processMessage(IoSession protocolSession, Message message) throws
105105
}
106106
} else {
107107
log.warn("Ignoring non-logon message before session establishment: " + message);
108-
protocolSession.close(true);
108+
protocolSession.closeNow();
109109
return;
110110
}
111111
}

quickfixj-core/src/test/java/quickfix/JdbcTestSupport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import java.sql.SQLException;
2727
import java.sql.Statement;
2828

29-
import junit.framework.Assert;
29+
import org.junit.Assert;
3030

3131
import org.logicalcobwebs.proxool.ProxoolException;
3232
import org.logicalcobwebs.proxool.ProxoolFacade;

quickfixj-core/src/test/java/quickfix/LoginTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
package quickfix;
2121

22-
import static junit.framework.Assert.*;
22+
import static org.junit.Assert.*;
2323
import static quickfix.FixVersions.*;
2424

2525
import java.util.HashMap;

quickfixj-core/src/test/java/quickfix/RepeatingGroupTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919

2020
package quickfix;
2121

22-
import junit.framework.Assert;
2322
import junit.framework.TestCase;
23+
import org.junit.Assert;
2424
import quickfix.field.BeginString;
2525
import quickfix.field.LegSymbol;
2626
import quickfix.field.OrderID;

quickfixj-core/src/test/java/quickfix/mina/IoSessionResponderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,13 @@ public void testSynchronousSendWithJoinTimeout() throws Exception {
100100
public void testDisconnect() throws Exception {
101101
IoSession mockProtocolSession = mock(IoSession.class);
102102
stub(mockProtocolSession.getScheduledWriteMessages()).toReturn(0);
103-
stub(mockProtocolSession.close(true)).toReturn(null);
103+
stub(mockProtocolSession.closeNow()).toReturn(null);
104104

105105
IoSessionResponder responder = new IoSessionResponder(mockProtocolSession, false, 0, 0);
106106
responder.disconnect();
107107

108108
verify(mockProtocolSession).getScheduledWriteMessages();
109-
verify(mockProtocolSession).close(true);
109+
verify(mockProtocolSession).closeNow();
110110

111111
verifyNoMoreInteractions(mockProtocolSession);
112112
}

quickfixj-core/src/test/java/quickfix/mina/ssl/X509TrustManagerWrapperTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@
66
import javax.net.ssl.TrustManager;
77
import javax.net.ssl.X509TrustManager;
88

9+
import org.junit.Assert;
910
import org.junit.Before;
1011
import org.junit.Test;
1112
import org.mockito.Mockito;
1213

13-
import junit.framework.Assert;
14-
1514
public class X509TrustManagerWrapperTest {
1615

1716
private X509TrustManagerWrapper underTest;

quickfixj-core/src/test/java/quickfix/test/acceptance/ATApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
import java.io.IOException;
2323

24-
import junit.framework.Assert;
24+
import org.junit.Assert;
2525

2626
import quickfix.Application;
2727
import quickfix.DoNotSend;

quickfixj-core/src/test/java/quickfix/test/acceptance/ATServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@
3333
import java.util.concurrent.CountDownLatch;
3434
import java.util.concurrent.TimeUnit;
3535

36-
import junit.framework.Assert;
3736
import junit.framework.TestSuite;
3837

3938
import org.apache.mina.core.filterchain.IoFilterChainBuilder;
39+
import org.junit.Assert;
4040
import org.slf4j.Logger;
4141
import org.slf4j.LoggerFactory;
4242

0 commit comments

Comments
 (0)