Skip to content

Commit 9565b9a

Browse files
author
Guido Medina
committed
Removed quickfixj-messages-all dependency from individual quickfixj-messages-fixXX dependencies.
Set JUnit tests version to 4.12 and centralized it to a Maven property.
1 parent 8c74944 commit 9565b9a

File tree

13 files changed

+34
-32
lines changed

13 files changed

+34
-32
lines changed

‎pom.xml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@
6969
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
7070
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
7171
<jdkLevel>1.7</jdkLevel>
72-
<slf4j.version>1.7.19</slf4j.version>
72+
<slf4j.version>1.7.21</slf4j.version>
73+
<junit.version>4.12</junit.version>
7374
<mainClass/>
7475

7576
<maven-resources-plugin-version>2.7</maven-resources-plugin-version>

‎quickfixj-core/pom.xml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<dependency>
2323
<groupId>junit</groupId>
2424
<artifactId>junit</artifactId>
25-
<version>4.12</version>
25+
<version>${junit.version}</version>
2626
<scope>test</scope>
2727
</dependency>
2828
<dependency>
@@ -236,6 +236,7 @@
236236
<plugin>
237237
<groupId>org.apache.maven.plugins</groupId>
238238
<artifactId>maven-jar-plugin</artifactId>
239+
<version>${maven-jar-plugin-version}</version>
239240
<configuration>
240241
<includes>
241242
<include>quickfix/**</include>
@@ -326,7 +327,7 @@
326327
</plugin>
327328
<plugin>
328329
<artifactId>maven-javadoc-plugin</artifactId>
329-
<version>2.10.3</version>
330+
<version>${maven-javadoc-plugin-version}</version>
330331
</plugin>
331332
<plugin>
332333
<artifactId>maven-jxr-plugin</artifactId>

‎quickfixj-distribution/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@
128128
<!-- generate javadocs into apidocs folder -->
129129
<plugin>
130130
<artifactId>maven-javadoc-plugin</artifactId>
131-
<version>2.10.3</version>
131+
<version>${maven-javadoc-plugin-version}</version>
132132
<executions>
133133
<execution>
134134
<id>javadoc-jar</id>

‎quickfixj-messages/quickfixj-messages-all/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<dependency>
2525
<groupId>junit</groupId>
2626
<artifactId>junit</artifactId>
27-
<version>4.10</version>
27+
<version>${junit.version}</version>
2828
<scope>test</scope>
2929
</dependency>
3030
</dependencies>

‎quickfixj-messages/quickfixj-messages-fix40/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dependencies>
1818
<dependency>
1919
<groupId>org.quickfixj</groupId>
20-
<artifactId>quickfixj-messages-all</artifactId>
20+
<artifactId>quickfixj-core</artifactId>
2121
<version>${project.version}</version>
2222
</dependency>
2323
</dependencies>
@@ -62,9 +62,9 @@
6262
</executions>
6363
</plugin>
6464
<plugin>
65-
<artifactId>maven-jar-plugin</artifactId>
6665
<groupId>org.apache.maven.plugins</groupId>
67-
<version>2.6</version>
66+
<artifactId>maven-jar-plugin</artifactId>
67+
<version>${maven-jar-plugin-version}</version>
6868
<configuration>
6969
<classesDirectory>${project.basedir}/../quickfixj-messages-all/target/classes/</classesDirectory>
7070
<includes>

‎quickfixj-messages/quickfixj-messages-fix41/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dependencies>
1818
<dependency>
1919
<groupId>org.quickfixj</groupId>
20-
<artifactId>quickfixj-messages-all</artifactId>
20+
<artifactId>quickfixj-core</artifactId>
2121
<version>${project.version}</version>
2222
</dependency>
2323
</dependencies>
@@ -63,9 +63,9 @@
6363
</plugin>
6464

6565
<plugin>
66-
<artifactId>maven-jar-plugin</artifactId>
6766
<groupId>org.apache.maven.plugins</groupId>
68-
<version>2.6</version>
67+
<artifactId>maven-jar-plugin</artifactId>
68+
<version>${maven-jar-plugin-version}</version>
6969
<configuration>
7070
<classesDirectory>${project.basedir}/../quickfixj-messages-all/target/classes/</classesDirectory>
7171
<includes>

‎quickfixj-messages/quickfixj-messages-fix42/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dependencies>
1818
<dependency>
1919
<groupId>org.quickfixj</groupId>
20-
<artifactId>quickfixj-messages-all</artifactId>
20+
<artifactId>quickfixj-core</artifactId>
2121
<version>${project.version}</version>
2222
</dependency>
2323
</dependencies>
@@ -63,9 +63,9 @@
6363
</plugin>
6464

6565
<plugin>
66-
<artifactId>maven-jar-plugin</artifactId>
6766
<groupId>org.apache.maven.plugins</groupId>
68-
<version>2.6</version>
67+
<artifactId>maven-jar-plugin</artifactId>
68+
<version>${maven-jar-plugin-version}</version>
6969
<configuration>
7070
<classesDirectory>${project.basedir}/../quickfixj-messages-all/target/classes/</classesDirectory>
7171
<includes>

‎quickfixj-messages/quickfixj-messages-fix43/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dependencies>
1818
<dependency>
1919
<groupId>org.quickfixj</groupId>
20-
<artifactId>quickfixj-messages-all</artifactId>
20+
<artifactId>quickfixj-core</artifactId>
2121
<version>${project.version}</version>
2222
</dependency>
2323
</dependencies>
@@ -63,9 +63,9 @@
6363
</plugin>
6464

6565
<plugin>
66-
<artifactId>maven-jar-plugin</artifactId>
6766
<groupId>org.apache.maven.plugins</groupId>
68-
<version>2.6</version>
67+
<artifactId>maven-jar-plugin</artifactId>
68+
<version>${maven-jar-plugin-version}</version>
6969
<configuration>
7070
<classesDirectory>${project.basedir}/../quickfixj-messages-all/target/classes/</classesDirectory>
7171
<includes>

‎quickfixj-messages/quickfixj-messages-fix44/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dependencies>
1818
<dependency>
1919
<groupId>org.quickfixj</groupId>
20-
<artifactId>quickfixj-messages-all</artifactId>
20+
<artifactId>quickfixj-core</artifactId>
2121
<version>${project.version}</version>
2222
</dependency>
2323
</dependencies>
@@ -63,9 +63,9 @@
6363
</plugin>
6464

6565
<plugin>
66-
<artifactId>maven-jar-plugin</artifactId>
6766
<groupId>org.apache.maven.plugins</groupId>
68-
<version>2.6</version>
67+
<artifactId>maven-jar-plugin</artifactId>
68+
<version>${maven-jar-plugin-version}</version>
6969
<configuration>
7070
<classesDirectory>${project.basedir}/../quickfixj-messages-all/target/classes/</classesDirectory>
7171
<includes>

‎quickfixj-messages/quickfixj-messages-fix50/pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<dependencies>
1818
<dependency>
1919
<groupId>org.quickfixj</groupId>
20-
<artifactId>quickfixj-messages-all</artifactId>
20+
<artifactId>quickfixj-core</artifactId>
2121
<version>${project.version}</version>
2222
</dependency>
2323
</dependencies>
@@ -63,9 +63,9 @@
6363
</plugin>
6464

6565
<plugin>
66-
<artifactId>maven-jar-plugin</artifactId>
6766
<groupId>org.apache.maven.plugins</groupId>
68-
<version>2.6</version>
67+
<artifactId>maven-jar-plugin</artifactId>
68+
<version>${maven-jar-plugin-version}</version>
6969
<configuration>
7070
<classesDirectory>${project.basedir}/../quickfixj-messages-all/target/classes/</classesDirectory>
7171
<includes>

0 commit comments

Comments
 (0)