improved exception message

Author: chrjohn

quickfixj-base/src/main/java/quickfix/DataDictionary.java

@@ -1155,8 +1155,7 @@ private void load(InputStream inputStream, DocumentBuilderFactory factory) throw
     private int getIntegerAttributeIfDefined(final Element documentElement, final String attribute) throws ConfigError {
         try {
             return documentElement.hasAttribute(attribute)
-                    // TODO
-                    ? Integer.valueOf(documentElement.getAttribute(attribute)) : 0;
+                    ? Integer.parseInt(documentElement.getAttribute(attribute)) : 0;
         } catch (NumberFormatException e) {
             throw new ConfigError("Attribute " + attribute + " could not be parsed as Integer.", e);
         }
@@ -1171,7 +1170,7 @@ private void load(Document document, String msgtype, Node node) throws ConfigErr
         final NodeList fieldNodes = node.getChildNodes();
 
         if (countElementNodes(fieldNodes) == 0 && (msgtype == HEADER_ID || msgtype == TRAILER_ID)) {
-            throw new ConfigError("No fields found: msgType=" + msgtype);
+            throw new ConfigError("No fields found in " + msgtype);
         }
 
         for (int j = 0; j < fieldNodes.getLength(); j++) {

quickfixj-base/src/test/java/quickfix/DataDictionaryTest.java

@@ -275,7 +275,7 @@ public void testHeaderWithNoChildren40() throws Exception {
         data += "</fix>";
 
         expectedException.expect(ConfigError.class);
-        expectedException.expectMessage("No fields found: msgType=HEADER");
+        expectedException.expectMessage("No fields found in HEADER");
 
         new DataDictionary(new ByteArrayInputStream(data.getBytes()));
     }
@@ -302,7 +302,7 @@ public void testHeaderWithTextElement40() throws Exception {
         data += "</fix>";
 
         expectedException.expect(ConfigError.class);
-        expectedException.expectMessage("No fields found: msgType=HEADER");
+        expectedException.expectMessage("No fields found in HEADER");
 
         new DataDictionary(new ByteArrayInputStream(data.getBytes()));
     }
@@ -328,7 +328,7 @@ public void testTrailerWithNoChildren40() throws Exception {
         data += "</fix>";
 
         expectedException.expect(ConfigError.class);
-        expectedException.expectMessage("No fields found: msgType=TRAILER");
+        expectedException.expectMessage("No fields found in TRAILER");
 
         new DataDictionary(new ByteArrayInputStream(data.getBytes()));
     }
@@ -355,7 +355,7 @@ public void testTrailerWithTextElement40() throws Exception {
         data += "</fix>";
 
         expectedException.expect(ConfigError.class);
-        expectedException.expectMessage("No fields found: msgType=TRAILER");
+        expectedException.expectMessage("No fields found in TRAILER");
 
         new DataDictionary(new ByteArrayInputStream(data.getBytes()));
     }