Skip to content

Commit 582e2d2

Browse files
andreydpAndrii Poletaiev
authored andcommitted
MR review changes, Copy constructor should retain setting
1 parent 7a32f28 commit 582e2d2

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

quickfixj-base/src/main/java/quickfix/ValidationSettings.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public ValidationSettings(ValidationSettings validationSettings) {
3535
this.checkUserDefinedFields = validationSettings.checkUserDefinedFields;
3636
this.checkUnorderedGroupFields = validationSettings.checkUnorderedGroupFields;
3737
this.allowUnknownMessageFields = validationSettings.allowUnknownMessageFields;
38+
this.firstFieldInGroupIsDelimiter = validationSettings.firstFieldInGroupIsDelimiter;
3839
}
3940

4041
/**

quickfixj-base/src/test/java/quickfix/ValidationSettingsTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ public void copyConstructor_retains_settings() {
1414
validationSettings.setCheckFieldsOutOfOrder(false);
1515
validationSettings.setCheckUnorderedGroupFields(false);
1616
validationSettings.setCheckUserDefinedFields(false);
17+
validationSettings.setFirstFieldInGroupIsDelimiter(true);
1718

1819
ValidationSettings validationSettingsCopy = new ValidationSettings(validationSettings);
1920

@@ -22,5 +23,6 @@ public void copyConstructor_retains_settings() {
2223
assertEquals(validationSettingsCopy.isCheckFieldsOutOfOrder(), validationSettings.isCheckFieldsOutOfOrder());
2324
assertEquals(validationSettingsCopy.isCheckUnorderedGroupFields(), validationSettings.isCheckUnorderedGroupFields());
2425
assertEquals(validationSettingsCopy.isCheckUserDefinedFields(), validationSettings.isCheckUserDefinedFields());
26+
assertEquals(validationSettingsCopy.isFirstFieldInGroupIsDelimiter(), validationSettings.isFirstFieldInGroupIsDelimiter());
2527
}
2628
}

0 commit comments

Comments
 (0)