Removed unnecessary DataDictionary.Exception class

Author: amichair

quickfixj-core/src/main/java/quickfix/DataDictionary.java

@@ -550,7 +550,7 @@ private static <K, V> void copyMap(Map<K, V> lhs, Map<K, V> rhs) {
                     copy = (Collection<V>) value.getClass().newInstance();
                 } catch (final RuntimeException e) {
                     throw e;
-                } catch (final java.lang.Exception e) {
+                } catch (final Exception e) {
                     throw new RuntimeException(e);
                 }
                 copyCollection(copy, (Collection<V>) value);
@@ -817,12 +817,12 @@ private void read(String location) throws ConfigError {
         final InputStream inputStream = FileUtil.open(getClass(), location, URL, FILESYSTEM,
                 CONTEXT_RESOURCE, CLASSLOADER_RESOURCE);
         if (inputStream == null) {
-            throw new DataDictionary.Exception("Could not find data dictionary: " + location);
+            throw new ConfigError("Could not find data dictionary: " + location);
         }
 
         try {
             load(inputStream);
-        } catch (final java.lang.Exception e) {
+        } catch (final Exception e) {
             throw new ConfigError(location + ": " + e.getMessage(), e);
         } finally {
             try {
@@ -1183,20 +1183,6 @@ private String getAttribute(Node node, String name, String defaultValue) {
         return defaultValue;
     }
 
-    /**
-     * Data dictionary-related exception.
-     */
-    public static class Exception extends RuntimeException {
-
-        public Exception(Throwable cause) {
-            super(cause);
-        }
-
-        public Exception(String message) {
-            super(message);
-        }
-    }
-
     private static final class IntStringPair {
         private final int intValue;
 

quickfixj-core/src/test/java/quickfix/DefaultSessionFactoryTest.java

@@ -134,7 +134,7 @@ private void createSessionAndAssertDictionaryNotFound() throws ConfigError {
         try {
             factory.create(sessionID, settings);
             fail("no data dictionary exception");
-        } catch (DataDictionary.Exception e) {
+        } catch (ConfigError e) {
             assertTrue("exception message not matched, expected: " + "... Could not find data ..."
                     + ", got: " + e.getMessage(),
                     e.getMessage().contains("Could not find data"));