Extracted Trailer fields array into constant

amichair · amichair · commit 27c1edff3368 · 2016-06-05T15:28:28.000+03:00
diff --git a/quickfixj-core/src/main/java/quickfix/Message.java b/quickfixj-core/src/main/java/quickfix/Message.java
@@ -373,6 +373,7 @@ public static class Trailer extends FieldMap {
         static final long serialVersionUID = -3193357271891865972L;
         private static final int[] TRAILER_FIELD_ORDER = { SignatureLength.FIELD, Signature.FIELD,
                 CheckSum.FIELD };
+        private static final int[] TRAILER_POST_FIELDS = { CheckSum.FIELD };
 
         public Trailer() {
             super(TRAILER_FIELD_ORDER);
@@ -384,7 +385,7 @@ public Trailer(int[] fieldOrder) {
 
         @Override
         protected void calculateString(StringBuilder buffer, int[] excludedFields, int[] postFields) {
-            super.calculateString(buffer, null, new int[] { CheckSum.FIELD });
+            super.calculateString(buffer, null, TRAILER_POST_FIELDS);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -373,6 +373,7 @@ public static class Trailer extends FieldMap {`
`373`	`373`	`static final long serialVersionUID = -3193357271891865972L;`
`374`	`374`	`private static final int[] TRAILER_FIELD_ORDER = { SignatureLength.FIELD, Signature.FIELD,`
`375`	`375`	`CheckSum.FIELD };`
	`376`	`+ private static final int[] TRAILER_POST_FIELDS = { CheckSum.FIELD };`
`376`	`377`
`377`	`378`	`public Trailer() {`
`378`	`379`	`super(TRAILER_FIELD_ORDER);`
`@@ -384,7 +385,7 @@ public Trailer(int[] fieldOrder) {`
`384`	`385`
`385`	`386`	`@Override`
`386`	`387`	`protected void calculateString(StringBuilder buffer, int[] excludedFields, int[] postFields) {`
`387`		`- super.calculateString(buffer, null, new int[] { CheckSum.FIELD });`
	`388`	`+ super.calculateString(buffer, null, TRAILER_POST_FIELDS);`
`388`	`389`	`}`
`389`	`390`	`}`
`390`	`391`