Move canonicalize_path fully into its own module

canonicalize_path has its own test .cpp and implementation .cpp, but its
header bits are shared in file.h. Formally make a separate
file-canonical module.

This commit should not change behavior.

Author: strager

src/CMakeLists.txt

@@ -84,6 +84,7 @@ quick_lint_js_add_library(
   quick-lint-js/error.h
   quick-lint-js/expression.h
   quick-lint-js/feature.h
+  quick-lint-js/file-canonical.h
   quick-lint-js/file-handle.h
   quick-lint-js/file-path.h
   quick-lint-js/file.h

src/configuration-loader.cpp

@@ -4,6 +4,7 @@
 #include <quick-lint-js/assert.h>
 #include <quick-lint-js/configuration-loader.h>
 #include <quick-lint-js/configuration.h>
+#include <quick-lint-js/file-canonical.h>
 #include <quick-lint-js/file-path.h>
 #include <quick-lint-js/file.h>
 #include <quick-lint-js/options.h>

src/file-canonical.cpp

@@ -10,9 +10,11 @@
 #include <cstring>
 #include <quick-lint-js/assert.h>
 #include <quick-lint-js/char8.h>
+#include <quick-lint-js/file-canonical.h>
+#include <quick-lint-js/file-handle.h>
 #include <quick-lint-js/file-path.h>
-#include <quick-lint-js/file.h>
 #include <quick-lint-js/have.h>
+#include <quick-lint-js/narrow-cast.h>
 #include <quick-lint-js/string-view.h>
 #include <quick-lint-js/utf-16.h>
 #include <string>

src/quick-lint-js/file-canonical.h

@@ -0,0 +1,54 @@
+// Copyright (C) 2020  Matthew "strager" Glazar
+// See end of file for extended copyright information.
+
+#ifndef QUICK_LINT_JS_FILE_CANONICAL_H
+#define QUICK_LINT_JS_FILE_CANONICAL_H
+
+#include <string>
+
+namespace quick_lint_js {
+class canonical_path_result {
+ public:
+  explicit canonical_path_result(std::string &&path);
+  explicit canonical_path_result(const char *path);
+
+  std::string_view path() const &noexcept;
+  std::string &&path() && noexcept;
+  const char *c_str() const noexcept;
+
+  std::string &&error() && noexcept;
+
+  bool ok() const noexcept { return this->error_.empty(); }
+
+  static canonical_path_result failure(std::string &&error);
+
+ private:
+  explicit canonical_path_result();
+
+  std::string path_;
+  std::string error_;
+};
+
+canonical_path_result canonicalize_path(const char *path);
+canonical_path_result canonicalize_path(const std::string &path);
+}
+
+#endif
+
+// quick-lint-js finds bugs in JavaScript programs.
+// Copyright (C) 2020  Matthew "strager" Glazar
+//
+// This file is part of quick-lint-js.
+//
+// quick-lint-js is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// quick-lint-js is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with quick-lint-js.  If not, see <https://www.gnu.org/licenses/>.

src/quick-lint-js/file.h

@@ -29,31 +29,6 @@ read_file_result read_stdin(void);
 
 void write_file(const std::string &path, string8_view content);
 void write_file(const char *path, string8_view content);
-
-class canonical_path_result {
- public:
-  explicit canonical_path_result(std::string &&path);
-  explicit canonical_path_result(const char *path);
-
-  std::string_view path() const &noexcept;
-  std::string &&path() && noexcept;
-  const char *c_str() const noexcept;
-
-  std::string &&error() && noexcept;
-
-  bool ok() const noexcept { return this->error_.empty(); }
-
-  static canonical_path_result failure(std::string &&error);
-
- private:
-  explicit canonical_path_result();
-
-  std::string path_;
-  std::string error_;
-};
-
-canonical_path_result canonicalize_path(const char *path);
-canonical_path_result canonicalize_path(const std::string &path);
 }
 
 #endif

test/test-configuration-loader.cpp

@@ -8,6 +8,7 @@
 #include <gtest/gtest.h>
 #include <quick-lint-js/configuration-loader.h>
 #include <quick-lint-js/configuration.h>
+#include <quick-lint-js/file-canonical.h>
 #include <quick-lint-js/file-matcher.h>
 #include <quick-lint-js/file.h>
 #include <quick-lint-js/options.h>

test/test-file-canonical.cpp

@@ -13,8 +13,8 @@
 #include <gtest/gtest.h>
 #include <optional>
 #include <quick-lint-js/char8.h>
+#include <quick-lint-js/file-canonical.h>
 #include <quick-lint-js/file-matcher.h>
-#include <quick-lint-js/file.h>
 #include <quick-lint-js/have.h>
 #include <quick-lint-js/string-view.h>
 #include <quick-lint-js/temporary-directory.h>